Changeset 238568 in webkit

Timestamp:

Nov 27, 2018, 1:03:29 PM (8 years ago)

Author:

Ryan Haddad

Message:

Unreviewed, rolling out r238509.

Causes JSC tests to fail on iOS.

Reverted changeset:

"NaNs read from Wasm code needs to be be purified."
​https://bugs.webkit.org/show_bug.cgi?id=191056
​https://trac.webkit.org/changeset/238509

Location:

trunk

Files:

• JSTests/ChangeLog (modified) (1 diff)
• JSTests/wasm/regress/regress-191056.js (deleted)
• Source/JavaScriptCore/ChangeLog (modified) (1 diff)
• Source/JavaScriptCore/wasm/js/WebAssemblyModuleRecord.cpp (modified) (1 diff)

trunk/JSTests/ChangeLog

@@ +1 @@
+2018-11-27  Ryan Haddad  <ryanhaddad@apple.com>
+
+        Unreviewed, rolling out r238509.
+
+        Causes JSC tests to fail on iOS.
+
+        Reverted changeset:
+
+        "NaNs read from Wasm code needs to be be purified."
+        https://bugs.webkit.org/show_bug.cgi?id=191056
+        https://trac.webkit.org/changeset/238509
+
 2018-11-26  Caio Lima  <ticaiolima@gmail.com>
 

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2018-11-27  Ryan Haddad  <ryanhaddad@apple.com>
+
+        Unreviewed, rolling out r238509.
+
+        Causes JSC tests to fail on iOS.
+
+        Reverted changeset:
+
+        "NaNs read from Wasm code needs to be be purified."
+        https://bugs.webkit.org/show_bug.cgi?id=191056
+        https://trac.webkit.org/changeset/238509
+
 2018-11-27  Mark Lam  <mark.lam@apple.com>
 

trunk/Source/JavaScriptCore/wasm/js/WebAssemblyModuleRecord.cpp

@@ -389 +389 @@
 
             case Wasm::F32:
-                exportedValue = jsNumber(purifyNaN(m_instance->instance().loadF32Global(exp.kindIndex)));
+                exportedValue = JSValue(m_instance->instance().loadF32Global(exp.kindIndex));
                 break;
 
             case Wasm::F64:
-                exportedValue = jsNumber(purifyNaN(m_instance->instance().loadF64Global(exp.kindIndex)));
+                exportedValue = JSValue(m_instance->instance().loadF64Global(exp.kindIndex));
                 break;