Changeset 238752 in webkit

Timestamp:

Nov 30, 2018, 1:27:54 PM (8 years ago)

Author:

Devin Rousso

Message:

Web Inspector: Settings: reload button needs horizontal spacing
​https://bugs.webkit.org/show_bug.cgi?id=192231
<rdar://problem/46274363>

Reviewed by Matt Baker.

• UserInterface/Views/SettingsTabContentView.css:

(.content-view.settings > .settings-view > .container button):
(.content-view.settings > .settings-view > .container > .title):
(.content-view.settings > .settings-view > .container > .editor-group > .editor input[type="checkbox"]):
(body[dir=ltr] .content-view.settings > .settings-view > .container > .title): Deleted.
(body[dir=rtl] .content-view.settings > .settings-view > .container > .title): Deleted.
(body[dir=ltr] .content-view.settings > .settings-view > .container > .editor-group > .editor input[type="checkbox"]): Deleted.
(body[dir=rtl] .content-view.settings > .settings-view > .container > .editor-group > .editor input[type="checkbox"]): Deleted.
Drive-by: replace dir=* attribute rules with -webkit-margin-* properties.

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Views/SettingsTabContentView.css (modified) (2 diffs)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2018-11-30  Devin Rousso  <drousso@apple.com>
+
+        Web Inspector: Settings: reload button needs horizontal spacing
+        https://bugs.webkit.org/show_bug.cgi?id=192231
+        <rdar://problem/46274363>
+
+        Reviewed by Matt Baker.
+
+        * UserInterface/Views/SettingsTabContentView.css:
+        (.content-view.settings > .settings-view > .container button):
+        (.content-view.settings > .settings-view > .container > .title):
+        (.content-view.settings > .settings-view > .container > .editor-group > .editor input[type="checkbox"]):
+        (body[dir=ltr] .content-view.settings > .settings-view > .container > .title): Deleted.
+        (body[dir=rtl] .content-view.settings > .settings-view > .container > .title): Deleted.
+        (body[dir=ltr] .content-view.settings > .settings-view > .container > .editor-group > .editor input[type="checkbox"]): Deleted.
+        (body[dir=rtl] .content-view.settings > .settings-view > .container > .editor-group > .editor input[type="checkbox"]): Deleted.
+        Drive-by: replace `dir=*` attribute rules with `-webkit-margin-*` properties.
+
 2018-11-30  Joseph Pecoraro  <pecoraro@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.css

@@ -70 +70 @@
 
 .content-view.settings > .settings-view > .container button {
+    -webkit-margin-end: 4px;
     font-size: inherit;
 }
 
 .content-view.settings > .settings-view > .container > .title {
+    width: 50%;
     margin-top: 2px;
-    width: 50%;
+    -webkit-margin-end: 6px;
     text-align: end;
-
-    --setting-name-margin-end: 6px;
-}
-
-body[dir=ltr] .content-view.settings > .settings-view > .container > .title {
-    margin-right: var(--setting-name-margin-end);
-}
-
-body[dir=rtl] .content-view.settings > .settings-view > .container > .title {
-    margin-left: var(--setting-name-margin-end);
 }
 
@@ -99 +91 @@
 
 .content-view.settings > .settings-view > .container > .editor-group > .editor input[type="checkbox"] {
+    -webkit-margin-end: 4px;
     /* Vertically align <select> with the group title text. */
     font-size: 16px;
-
-    --settings-input-checkbox-margin-end: 4px;
-}
-
-body[dir=ltr] .content-view.settings > .settings-view > .container > .editor-group > .editor input[type="checkbox"] {
-    margin-right: var(--settings-input-checkbox-margin-end);
-}
-
-body[dir=rtl] .content-view.settings > .settings-view > .container > .editor-group > .editor input[type="checkbox"] {
-    margin-left: var(--settings-input-checkbox-margin-end);
 }