Changeset 23881 in webkit


Ignore:
Timestamp:
Jun 29, 2007 11:15:40 AM (17 years ago)
Author:
adele
Message:

LayoutTests:

Reviewed by Ada and Kevin McCullough.

Test for <rdar://problem/5301322> REGRESSION: Select All selects the whole page when used in readonly textareas

  • fast/forms/input-readonly-select-all-expected.checksum: Added.
  • fast/forms/input-readonly-select-all-expected.png: Added.
  • fast/forms/input-readonly-select-all-expected.txt: Added.
  • fast/forms/input-readonly-select-all.html: Added.
  • fast/forms/textarea-readonly-select-all-expected.checksum: Added.
  • fast/forms/textarea-readonly-select-all-expected.png: Added.
  • fast/forms/textarea-readonly-select-all-expected.txt: Added.
  • fast/forms/textarea-readonly-select-all.html: Added.

WebCore:

Reviewed by Ada and Kevin McCullough.

Fix for <rdar://problem/5301322> REGRESSION: Select All selects the whole page when used in readonly textareas

Implemented canSelectAll and selectAll for text fields and textareas, since they're special cases even when they're not editable.

Tests:
fast/forms/input-readonly-select-all.html
fast/forms/textarea-readonly-select-all.html

  • html/HTMLInputElement.h: (WebCore::HTMLInputElement::canSelectAll): (WebCore::HTMLInputElement::selectAll):
  • html/HTMLTextAreaElement.h: (WebCore::HTMLTextAreaElement::canSelectAll): (WebCore::HTMLTextAreaElement::selectAll):
Location:
trunk
Files:
8 added
4 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r23866 r23881  
     12007-06-29  Adele Peterson  <adele@apple.com>
     2
     3        Reviewed by Ada and Kevin McCullough.
     4
     5        Test for <rdar://problem/5301322> REGRESSION: Select All selects the whole page when used in readonly textareas
     6
     7        * fast/forms/input-readonly-select-all-expected.checksum: Added.
     8        * fast/forms/input-readonly-select-all-expected.png: Added.
     9        * fast/forms/input-readonly-select-all-expected.txt: Added.
     10        * fast/forms/input-readonly-select-all.html: Added.
     11        * fast/forms/textarea-readonly-select-all-expected.checksum: Added.
     12        * fast/forms/textarea-readonly-select-all-expected.png: Added.
     13        * fast/forms/textarea-readonly-select-all-expected.txt: Added.
     14        * fast/forms/textarea-readonly-select-all.html: Added.
     15
    1162007-06-28  Mitz Pettel  <mitz@webkit.org>
    217

  • trunk/WebCore/ChangeLog

    r23880 r23881  
     12007-06-29  Adele Peterson  <adele@apple.com>
     2
     3        Reviewed by Ada and Kevin McCullough.
     4
     5        Fix for <rdar://problem/5301322> REGRESSION: Select All selects the whole page when used in readonly textareas
     6
     7        Implemented canSelectAll and selectAll for text fields and textareas, since they're special cases even when they're not editable.
     8
     9        Tests:
     10        fast/forms/input-readonly-select-all.html
     11        fast/forms/textarea-readonly-select-all.html
     12
     13        * html/HTMLInputElement.h:
     14        (WebCore::HTMLInputElement::canSelectAll):
     15        (WebCore::HTMLInputElement::selectAll):
     16        * html/HTMLTextAreaElement.h:
     17        (WebCore::HTMLTextAreaElement::canSelectAll):
     18        (WebCore::HTMLTextAreaElement::selectAll):
     19
    1202007-06-29  Adam Roben  <aroben@apple.com>
    221

  • trunk/WebCore/html/HTMLInputElement.h

    r21869 r23881  
    6767    virtual void updateFocusAppearance(bool restorePreviousSelection = false);
    6868    virtual void aboutToUnload();
    69 
     69    virtual bool canSelectAll() const { return isTextField(); }
     70    virtual void selectAll() { select(); }
    7071    virtual const AtomicString& name() const;
    7172

  • trunk/WebCore/html/HTMLTextAreaElement.h

    r20072 r23881  
    7575    virtual void focus(bool restorePreviousSelection = true);
    7676    virtual void updateFocusAppearance(bool restorePreviousSelection = true);
    77 
     77    virtual bool canSelectAll() const { return true; }
     78    virtual void selectAll() { select(); }
     79   
    7880    String value() const;
    7981    void setValue(const String&);
Note: See TracChangeset for help on using the changeset viewer.