Changeset 239374 in webkit

Timestamp:

Dec 19, 2018, 3:20:16 AM (8 years ago)

Author:

aboya@igalia.com

Message:

[MSE] Remove dead code: sourceBufferPrivateSeekToTime()
​https://bugs.webkit.org/show_bug.cgi?id=192827

Reviewed by Xabier Rodriguez-Calvar.

This patch makes two dead code removal changes in
SourceBufferPrivateClient:

First, sourceBufferPrivateFastSeekTimeForMediaTime() is made pure
virtual in SourceBufferPrivateClient. Since SourceBufferPrivateClient
is only inherited by SourceBuffer, it makes no sense to have default
implementations there (they will never be used), moreso it being a
client interface.

Second, sourceBufferPrivateSeekToTime() is removed entirely. It used
to had an empty implementation, which SourceBuffer did not overwrite,
therefore making any calls to it useless.

All calls to sourceBufferPrivateSeekToTime() have been removed:

SourceBufferPrivateAVFObjC::seekToTime(), which was also dead code
itself, used to call this method. This patch deletes it completely.

MockSourceBufferPrivate::seekToTime(), which only called this empty
method, has also been removed along with its only usage in
MockMediaSourcePrivate::seekToTime().

• platform/graphics/SourceBufferPrivateClient.h:

(WebCore::SourceBufferPrivateClient::sourceBufferPrivateFastSeekTimeForMediaTime): Deleted.
(WebCore::SourceBufferPrivateClient::sourceBufferPrivateSeekToTime): Deleted.

• platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.h:
• platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:

(WebCore::SourceBufferPrivateAVFObjC::seekToTime): Deleted.

• platform/mock/mediasource/MockMediaSourcePrivate.cpp:

(WebCore::MockMediaSourcePrivate::seekToTime):

• platform/mock/mediasource/MockSourceBufferPrivate.cpp:

(WebCore::MockSourceBufferPrivate::seekToTime): Deleted.

• platform/mock/mediasource/MockSourceBufferPrivate.h:

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/graphics/SourceBufferPrivateClient.h (modified) (1 diff)
• platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.h (modified) (1 diff)
• platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm (modified) (1 diff)
• platform/mock/mediasource/MockMediaSourcePrivate.cpp (modified) (1 diff)
• platform/mock/mediasource/MockSourceBufferPrivate.cpp (modified) (1 diff)
• platform/mock/mediasource/MockSourceBufferPrivate.h (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2018-12-19  Alicia Boya García  <aboya@igalia.com>
+
+        [MSE] Remove dead code: sourceBufferPrivateSeekToTime()
+        https://bugs.webkit.org/show_bug.cgi?id=192827
+
+        Reviewed by Xabier Rodriguez-Calvar.
+
+        This patch makes two dead code removal changes in
+        SourceBufferPrivateClient:
+
+        First, sourceBufferPrivateFastSeekTimeForMediaTime() is made pure
+        virtual in SourceBufferPrivateClient. Since SourceBufferPrivateClient
+        is only inherited by SourceBuffer, it makes no sense to have default
+        implementations there (they will never be used), moreso it being a
+        client interface.
+
+        Second, sourceBufferPrivateSeekToTime() is removed entirely. It used
+        to had an empty implementation, which SourceBuffer did not overwrite,
+        therefore making any calls to it useless.
+
+        All calls to sourceBufferPrivateSeekToTime() have been removed:
+
+        SourceBufferPrivateAVFObjC::seekToTime(), which was also dead code
+        itself, used to call this method. This patch deletes it completely.
+
+        MockSourceBufferPrivate::seekToTime(), which only called this empty
+        method, has also been removed along with its only usage in
+        MockMediaSourcePrivate::seekToTime().
+
+        * platform/graphics/SourceBufferPrivateClient.h:
+        (WebCore::SourceBufferPrivateClient::sourceBufferPrivateFastSeekTimeForMediaTime): Deleted.
+        (WebCore::SourceBufferPrivateClient::sourceBufferPrivateSeekToTime): Deleted.
+        * platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.h:
+        * platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:
+        (WebCore::SourceBufferPrivateAVFObjC::seekToTime): Deleted.
+        * platform/mock/mediasource/MockMediaSourcePrivate.cpp:
+        (WebCore::MockMediaSourcePrivate::seekToTime):
+        * platform/mock/mediasource/MockSourceBufferPrivate.cpp:
+        (WebCore::MockSourceBufferPrivate::seekToTime): Deleted.
+        * platform/mock/mediasource/MockSourceBufferPrivate.h:
+
 2018-12-19  Xabier Rodriguez Calvar  <calvaris@igalia.com>
 

trunk/Source/WebCore/platform/graphics/SourceBufferPrivateClient.h

@@ -72 +72 @@
     virtual void sourceBufferPrivateDidBecomeReadyForMoreSamples(const AtomicString& trackID) = 0;
 
-    virtual MediaTime sourceBufferPrivateFastSeekTimeForMediaTime(const MediaTime& time, const MediaTime&, const MediaTime&) { return time; }
-    virtual void sourceBufferPrivateSeekToTime(const MediaTime&) { };
+    virtual MediaTime sourceBufferPrivateFastSeekTimeForMediaTime(const MediaTime&, const MediaTime&, const MediaTime&) = 0;
 
     enum AppendResult { AppendSucceeded, ReadStreamFailed, ParsingFailed };

trunk/Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.h

@@ -103 +103 @@
 
     void willSeek();
-    void seekToTime(const MediaTime&);
     MediaTime fastSeekTimeForMediaTime(const MediaTime&, const MediaTime& negativeThreshold, const MediaTime& positiveThreshold);
     FloatSize naturalSize();

trunk/Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm

@@ -1172 +1172 @@
 }
 
-void SourceBufferPrivateAVFObjC::seekToTime(const MediaTime& time)
-{
-    if (m_client)
-        m_client->sourceBufferPrivateSeekToTime(time);
-}
-
 FloatSize SourceBufferPrivateAVFObjC::naturalSize()
 {

trunk/Source/WebCore/platform/mock/mediasource/MockMediaSourcePrivate.cpp

@@ -166 +166 @@
     }
 
-    for (auto& buffer : m_activeSourceBuffers)
-        buffer->seekToTime(seekTime);
-
     return seekTime;
 }

trunk/Source/WebCore/platform/mock/mediasource/MockSourceBufferPrivate.cpp

@@ -290 +290 @@
 }
 
-void MockSourceBufferPrivate::seekToTime(const MediaTime& time)
-{
-    if (m_client)
-        m_client->sourceBufferPrivateSeekToTime(time);
-}
-
 }
 

trunk/Source/WebCore/platform/mock/mediasource/MockSourceBufferPrivate.h

@@ -50 +50 @@
     bool hasAudio() const;
 
-    void seekToTime(const MediaTime&);
     MediaTime fastSeekTimeForMediaTime(const MediaTime&, const MediaTime& negativeThreshold, const MediaTime& positiveThreshold);