⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Changeset 239376 in webkit


Ignore:
Timestamp:
Dec 19, 2018, 3:37:39 AM (8 years ago)
Author:
aboya@igalia.com
Message:

[MSE] Remove unused method: stopAskingForMoreSamples()
​https://bugs.webkit.org/show_bug.cgi?id=192754

Reviewed by Xabier Rodriguez-Calvar.

The stopAskingForMoreSamples() method from SourceBufferPrivate is not
being used by anyone. SourceBuffer is not calling it and no
SourceBufferPrivate is implementing it. Let's remove that noise.

  • platform/graphics/SourceBufferPrivate.h:

(WebCore::SourceBufferPrivate::setActive):
(WebCore::SourceBufferPrivate::stopAskingForMoreSamples): Deleted.

  • platform/graphics/gstreamer/mse/SourceBufferPrivateGStreamer.cpp:

(WebCore::SourceBufferPrivateGStreamer::stopAskingForMoreSamples): Deleted.

  • platform/graphics/gstreamer/mse/SourceBufferPrivateGStreamer.h:
Location:
trunk/Source/WebCore
Files:
4 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebCore/ChangeLog

    r239374 r239376  
     12018-12-19  Alicia Boya García  <aboya@igalia.com>
     2
     3        [MSE] Remove unused method: stopAskingForMoreSamples()
     4        https://bugs.webkit.org/show_bug.cgi?id=192754
     5
     6        Reviewed by Xabier Rodriguez-Calvar.
     7
     8        The stopAskingForMoreSamples() method from SourceBufferPrivate is not
     9        being used by anyone. SourceBuffer is not calling it and no
     10        SourceBufferPrivate is implementing it. Let's remove that noise.
     11
     12        * platform/graphics/SourceBufferPrivate.h:
     13        (WebCore::SourceBufferPrivate::setActive):
     14        (WebCore::SourceBufferPrivate::stopAskingForMoreSamples): Deleted.
     15        * platform/graphics/gstreamer/mse/SourceBufferPrivateGStreamer.cpp:
     16        (WebCore::SourceBufferPrivateGStreamer::stopAskingForMoreSamples): Deleted.
     17        * platform/graphics/gstreamer/mse/SourceBufferPrivateGStreamer.h:
     18
    1192018-12-19  Alicia Boya García  <aboya@igalia.com>
    220

  • trunk/Source/WebCore/platform/graphics/SourceBufferPrivate.h

    r234940 r239376  
    6060    virtual bool isReadyForMoreSamples(const AtomicString&) { return false; }
    6161    virtual void setActive(bool) { }
    62     virtual void stopAskingForMoreSamples(const AtomicString&) { }
    6362    virtual void notifyClientWhenReadyForMoreSamples(const AtomicString&) { }
    6463

  • trunk/Source/WebCore/platform/graphics/gstreamer/mse/SourceBufferPrivateGStreamer.cpp

    r238892 r239376  
    149149}
    150150
    151 void SourceBufferPrivateGStreamer::stopAskingForMoreSamples(const AtomicString&)
    152 {
    153     notImplemented();
    154 }
    155 
    156151void SourceBufferPrivateGStreamer::notifyClientWhenReadyForMoreSamples(const AtomicString& trackId)
    157152{

  • trunk/Source/WebCore/platform/graphics/gstreamer/mse/SourceBufferPrivateGStreamer.h

    r238892 r239376  
    6868    bool isReadyForMoreSamples(const AtomicString&) final;
    6969    void setActive(bool) final;
    70     void stopAskingForMoreSamples(const AtomicString&) final;
    7170    void notifyClientWhenReadyForMoreSamples(const AtomicString&) final;
    7271
Note: See TracChangeset for help on using the changeset viewer.