Changeset 239385 in webkit

Timestamp:

Dec 19, 2018, 1:08:53 PM (8 years ago)

Author:

Nikita Vasilyev

Message:

Web Inspector: column sort controls in Layers tab sidebar don't render correctly in dark mode
​https://bugs.webkit.org/show_bug.cgi?id=192845

Reviewed by Devin Rousso.

• UserInterface/Views/DataGrid.css:

(@media (prefers-dark-interface)):
(.data-grid th.sortable:active):
Drive-by: replace obnoxiously light background of the pressed header with a more subtle gray.

(.data-grid th.sort-ascending > div:first-child::after, .data-grid th.sort-descending > div:first-child::after):
Invert colors of the arrow glyph.

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Views/DataGrid.css (modified) (1 diff)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2018-12-19  Nikita Vasilyev  <nvasilyev@apple.com>
+
+        Web Inspector: column sort controls in Layers tab sidebar don't render correctly in dark mode
+        https://bugs.webkit.org/show_bug.cgi?id=192845
+
+        Reviewed by Devin Rousso.
+
+        * UserInterface/Views/DataGrid.css:
+        (@media (prefers-dark-interface)):
+        (.data-grid th.sortable:active):
+        Drive-by: replace obnoxiously light background of the pressed header with a more subtle gray.
+
+        (.data-grid th.sort-ascending > div:first-child::after, .data-grid th.sort-descending > div:first-child::after):
+        Invert colors of the arrow glyph.
+
 2018-12-18  Devin Rousso  <drousso@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/Views/DataGrid.css

@@ -447 +447 @@
         background-color: unset;
     }
-}
+
+    .data-grid th.sortable:active {
+        background-color: hsl(0, 0%, 40%);
+    }
+
+    .data-grid th.sort-ascending > div:first-child::after,
+    .data-grid th.sort-descending > div:first-child::after {
+        filter: invert();
+    }
+}