Changeset 239405 in webkit

Timestamp:

Dec 19, 2018, 4:46:10 PM (8 years ago)

Author:

Matt Baker

Message:

Web Inspector: Elements tab: arrow key after undoing a DOM node delete selects the wrong element
​https://bugs.webkit.org/show_bug.cgi?id=192871
<rdar://problem/46849060>

Reviewed by Devin Rousso.

Undoing a DOM node removal reinserts the node into the DOMTreeOutline.
When the reinserted node precedes the selected node in the tree, the
SelectionController should update _lastSelectedIndex.

• UserInterface/Controllers/SelectionController.js:

(WI.SelectionController.prototype.didInsertItem):

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Controllers/SelectionController.js (modified) (1 diff)
• UserInterface/Views/TreeOutline.js (modified) (1 diff)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2018-12-19  Matt Baker  <mattbaker@apple.com>
+
+        Web Inspector: Elements tab: arrow key after undoing a DOM node delete selects the wrong element
+        https://bugs.webkit.org/show_bug.cgi?id=192871
+        <rdar://problem/46849060>
+
+        Reviewed by Devin Rousso.
+
+        Undoing a DOM node removal reinserts the node into the DOMTreeOutline.
+        When the reinserted node precedes the selected node in the tree, the
+        SelectionController should update `_lastSelectedIndex`.
+
+        * UserInterface/Controllers/SelectionController.js:
+        (WI.SelectionController.prototype.didInsertItem):
+
 2018-12-19  Devin Rousso  <drousso@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/Controllers/SelectionController.js

@@ -213 +213 @@
             current = this._selectedIndexes.indexLessThan(current);
         }
+
+        if (this._lastSelectedIndex >= index)
+            this._lastSelectedIndex += 1;
+        if (this._shiftAnchorIndex >= index)
+            this._shiftAnchorIndex += 1;
     }
 

trunk/Source/WebInspectorUI/UserInterface/Views/TreeOutline.js

@@ -407 +407 @@
 
         let index = this._indexOfTreeElement(element);
-        if (index >= 0)
+        if (index >= 0) {
+            console.assert(!element.selected, "TreeElement should not be selected before being inserted.");
             this._selectionController.didInsertItem(index);
+        }
     }