Changeset 239482 in webkit

Timestamp:

Dec 20, 2018 5:32:14 PM (5 years ago)

Author:

Wenson Hsieh

Message:

[iOS] Some layout tests are failing after r239441
​https://bugs.webkit.org/show_bug.cgi?id=192957
<rdar://problem/46781759>

Reviewed by Simon Fraser.

Fix several failing layout tests after r239441.

• fast/events/ios/click-event-while-editing-node.html:

This test started failing after r239441 because it taps the bottom of the editable element, and then expects
WebKit to scroll the web view up to reveal the touched location. This was exactly the bug that r239441 fixed, so
we should just make this test no longer depend on the broken behavior.

• fast/forms/ios/focus-long-textarea-expected.txt:
• fast/forms/ios/zoom-after-input-tap-wide-input-expected.txt:

Rebaseline a couple of test expectations to account for the change in margin around the selection rect, in
-[WKWebView _zoomToFocusRect:…:].

Location:

trunk/LayoutTests

Files:

• ChangeLog (modified) (1 diff)
• fast/events/ios/click-event-while-editing-node.html (modified) (1 diff)
• fast/forms/ios/focus-long-textarea-expected.txt (modified) (1 diff)
• fast/forms/ios/zoom-after-input-tap-wide-input-expected.txt (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2018-12-20  Wenson Hsieh  <wenson_hsieh@apple.com>
+
+        [iOS] Some layout tests are failing after r239441
+        https://bugs.webkit.org/show_bug.cgi?id=192957
+        <rdar://problem/46781759>
+
+        Reviewed by Simon Fraser.
+
+        Fix several failing layout tests after r239441.
+
+        * fast/events/ios/click-event-while-editing-node.html:
+
+        This test started failing after r239441 because it taps the bottom of the editable element, and then expects
+        WebKit to scroll the web view up to reveal the touched location. This was exactly the bug that r239441 fixed, so
+        we should just make this test no longer depend on the broken behavior.
+
+        * fast/forms/ios/focus-long-textarea-expected.txt:
+        * fast/forms/ios/zoom-after-input-tap-wide-input-expected.txt:
+
+        Rebaseline a couple of test expectations to account for the change in margin around the selection rect, in
+        -[WKWebView _zoomToFocusRect:…:].
+
 2018-12-20  Jiewen Tan  <jiewen_tan@apple.com>
 

trunk/LayoutTests/fast/events/ios/click-event-while-editing-node.html

@@ -25 +25 @@
     testRunner.dumpAsText();
     jsTestIsAsync = true;
-    UIHelper.activateAndWaitForInputSessionAt(50, 300).then(() => {
-        UIHelper.tapAt(50, 300).then(() => {
+    UIHelper.activateAndWaitForInputSessionAt(50, 200).then(() => {
+        UIHelper.tapAt(50, 200).then(() => {
             shouldBeEqualToString("document.getElementById('clicks').textContent", `${clickCount}`);
             finishJSTest();

trunk/LayoutTests/fast/forms/ios/focus-long-textarea-expected.txt

@@ -4 +4 @@
 tap location    { x: 38.000, y: 664.000 }
 scale   1.455
-visibleRect     { left: 0.000, top: 506.294, width: 219.979, height: 376.713 }
+visibleRect     { left: 0.000, top: 498.045, width: 219.979, height: 376.713 }

trunk/LayoutTests/fast/forms/ios/zoom-after-input-tap-wide-input-expected.txt

@@ -4 +4 @@
 tap location    { x: 328.000, y: 862.000 }
 scale   1.455
-visibleRect     { left: 122.707, top: 776.803, width: 219.980, height: 376.715 }
+visibleRect     { left: 114.458, top: 776.803, width: 219.980, height: 376.715 }