Changeset 239880 in webkit

Timestamp:

Jan 11, 2019, 3:30:07 PM (8 years ago)

Author:

timothy_horton@apple.com

Message:

REGRESSION (PSON): Firefox app lacks Open in New Tab in menu
​https://bugs.webkit.org/show_bug.cgi?id=193366
<rdar://problem/46097212>

Reviewed by Simon Fraser.

Source/WebCore:

• platform/RuntimeApplicationChecks.h:
• platform/cocoa/RuntimeApplicationChecksCocoa.mm:

(WebCore::IOSApplication::isFirefox):
Add a Firefox Mobile bundle check.

Source/WebKit:

A pair of unrelated changes broke Firefox's use of WKWebView internals
to override the long-press menu. Maintain binary compatibility by
introducing linked-on-or-after checks.

• UIProcess/Cocoa/VersionChecks.h:
• UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::createWebPage):
Disable PSON in Firefox when linked against an SDK where PSON wasn't enabled by default.
Because gestures are very stateful, we always swap them out when swapping
processes (changing that behavior is fairly risky). Also, we don't always
inform the client when we swap processes (only when the process actually crashes),
so they currently don't re-adjust the gesture recognizers when a PSON swap occurs.

• UIProcess/ios/WKContentView.mm:

(-[WKContentView _commonInitializationWithProcessPool:configuration:]):
Synchronously install gesture recognizers under -init when linked against
an SDK before the version that introduces lazy gesture recognizer installation.
r237331 is an optimization that made us lazily install gestures when the
view is parented, but Firefox (and potentially other clients) depend
on them being installed synchronously in order to find and override them.

Location:

trunk/Source

Files:

• WebCore/ChangeLog (modified) (1 diff)
• WebCore/platform/RuntimeApplicationChecks.h (modified) (1 diff)
• WebCore/platform/cocoa/RuntimeApplicationChecksCocoa.mm (modified) (1 diff)
• WebKit/ChangeLog (modified) (1 diff)
• WebKit/UIProcess/Cocoa/VersionChecks.h (modified) (2 diffs)
• WebKit/UIProcess/WebProcessPool.cpp (modified) (3 diffs)
• WebKit/UIProcess/ios/WKContentView.mm (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2019-01-11  Tim Horton  <timothy_horton@apple.com>
+
+        REGRESSION (PSON): Firefox app lacks Open in New Tab in menu
+        https://bugs.webkit.org/show_bug.cgi?id=193366
+        <rdar://problem/46097212>
+
+        Reviewed by Simon Fraser.
+
+        * platform/RuntimeApplicationChecks.h:
+        * platform/cocoa/RuntimeApplicationChecksCocoa.mm:
+        (WebCore::IOSApplication::isFirefox):
+        Add a Firefox Mobile bundle check.
+
 2019-01-11  Antti Koivisto  <antti@apple.com>
 

trunk/Source/WebCore/platform/RuntimeApplicationChecks.h

@@ -91 +91 @@
 WEBCORE_EXPORT bool isNike();
 bool isMoviStarPlus();
+WEBCORE_EXPORT bool isFirefox();
 
 } // IOSApplication

trunk/Source/WebCore/platform/cocoa/RuntimeApplicationChecksCocoa.mm

@@ -277 +277 @@
     return isMoviStarPlus;
 }
-    
+
+bool IOSApplication::isFirefox()
+{
+    static bool isFirefox = applicationBundleIsEqualTo("org.mozilla.ios.Firefox"_s);
+    return isFirefox;
+}
+
 #endif
 

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2019-01-11  Tim Horton  <timothy_horton@apple.com>
+
+        REGRESSION (PSON): Firefox app lacks Open in New Tab in menu
+        https://bugs.webkit.org/show_bug.cgi?id=193366
+        <rdar://problem/46097212>
+
+        Reviewed by Simon Fraser.
+
+        A pair of unrelated changes broke Firefox's use of WKWebView internals
+        to override the long-press menu. Maintain binary compatibility by
+        introducing linked-on-or-after checks.
+
+        * UIProcess/Cocoa/VersionChecks.h:
+        * UIProcess/WebProcessPool.cpp:
+        (WebKit::WebProcessPool::createWebPage):
+        Disable PSON in Firefox when linked against an SDK where PSON wasn't enabled by default.
+        Because gestures are very stateful, we always swap them out when swapping
+        processes (changing that behavior is fairly risky). Also, we don't always
+        inform the client when we swap processes (only when the process actually crashes),
+        so they currently don't re-adjust the gesture recognizers when a PSON swap occurs.
+
+        * UIProcess/ios/WKContentView.mm:
+        (-[WKContentView _commonInitializationWithProcessPool:configuration:]):
+        Synchronously install gesture recognizers under -init when linked against
+        an SDK before the version that introduces lazy gesture recognizer installation.
+        r237331 is an optimization that made us lazily install gestures when the
+        view is parented, but Firefox (and potentially other clients) depend
+        on them being installed synchronously in order to find and override them.
+
 2019-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
 

trunk/Source/WebKit/UIProcess/Cocoa/VersionChecks.h

@@ -28 +28 @@
 #import <wtf/spi/darwin/dyldSPI.h>
 
+#if USE(APPLE_INTERNAL_SDK)
+#import <WebKitAdditions/VersionChecksAdditions.h>
+#else
+#define DYLD_IOS_VERSION_FIRST_WITH_LAZY_GESTURE_RECOGNIZER_INSTALLATION 0
+#define DYLD_IOS_VERSION_FIRST_WITH_PROCESS_SWAP_ON_CROSS_SITE_NAVIGATION 0
+#endif
+
 namespace WebKit {
 
@@ -42 +49 @@
     FirstWhereUIScrollViewDoesNotApplyKeyboardInsetsUnconditionally = DYLD_IOS_VERSION_12_0,
     FirstWithMainThreadReleaseAssertionInWebPageProxy = DYLD_IOS_VERSION_12_0,
+    FirstWithLazyGestureRecognizerInstallation = DYLD_IOS_VERSION_FIRST_WITH_LAZY_GESTURE_RECOGNIZER_INSTALLATION,
+    FirstWithProcessSwapOnCrossSiteNavigation = DYLD_IOS_VERSION_FIRST_WITH_PROCESS_SWAP_ON_CROSS_SITE_NAVIGATION,
 #elif PLATFORM(MAC)
     FirstWithNetworkCache = DYLD_MACOSX_VERSION_10_11,

trunk/Source/WebKit/UIProcess/WebProcessPool.cpp

@@ -88 +88 @@
 #include <WebCore/ProcessWarming.h>
 #include <WebCore/ResourceRequest.h>
+#include <WebCore/RuntimeApplicationChecks.h>
 #include <pal/SessionID.h>
 #include <wtf/Language.h>
@@ -114 +115 @@
 #include "WaylandCompositor.h"
 #include <WebCore/PlatformDisplay.h>
+#endif
+
+#if PLATFORM(COCOA)
+#include "VersionChecks.h"
 #endif
 
@@ -1146 +1151 @@
 
     auto page = process->createWebPage(pageClient, WTFMove(pageConfiguration));
-    m_configuration->setProcessSwapsOnNavigationFromExperimentalFeatures(page->preferences().processSwapOnCrossSiteNavigationEnabled());
+
+    bool enableProcessSwapOnCrossSiteNavigation = page->preferences().processSwapOnCrossSiteNavigationEnabled();
+#if PLATFORM(IOS_FAMILY)
+    if (WebCore::IOSApplication::isFirefox() && !linkedOnOrAfter(WebKit::SDKVersion::FirstWithProcessSwapOnCrossSiteNavigation))
+        enableProcessSwapOnCrossSiteNavigation = false;
+#endif
+
+    m_configuration->setProcessSwapsOnNavigationFromExperimentalFeatures(enableProcessSwapOnCrossSiteNavigation);
     m_configuration->setShouldCaptureAudioInUIProcess(page->preferences().captureAudioInUIProcessEnabled());
     m_configuration->setShouldCaptureVideoInUIProcess(page->preferences().captureVideoInUIProcessEnabled());

trunk/Source/WebKit/UIProcess/ios/WKContentView.mm

@@ -40 +40 @@
 #import "SmartMagnificationController.h"
 #import "UIKitSPI.h"
+#import "VersionChecks.h"
 #import "WKBrowsingContextControllerInternal.h"
 #import "WKBrowsingContextGroupPrivate.h"
@@ -220 +221 @@
     [_fixedClippingView addSubview:_rootContentView.get()];
 
+    if (!linkedOnOrAfter(WebKit::SDKVersion::FirstWithLazyGestureRecognizerInstallation))
+        [self setupInteraction];
     [self setUserInteractionEnabled:YES];