Changeset 240082 in webkit

Timestamp:

Jan 16, 2019, 3:28:37 PM (8 years ago)

Author:

Alan Coon

Message:

Cherry-pick r239757. rdar://problem/47260195

[Mac] Layout Test http/wpt/webauthn/public-key-credential-create-success-hid.https.html and http/wpt/webauthn/public-key-credential-get-success-hid.https.html are flaky
​https://bugs.webkit.org/show_bug.cgi?id=192061

Reviewed by Dewei Zhu.

Part 6.

Add some additional temporary logging info to determine if data is actually sent.
Once the bug is determined and fixed, we should remove all logging added in this patch.

• UIProcess/WebAuthentication/Mock/MockHidConnection.cpp: (WebKit::MockHidConnection::send):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@239757 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Location:

branches/safari-607-branch/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/WebAuthentication/Mock/MockHidConnection.cpp (modified) (2 diffs)

branches/safari-607-branch/Source/WebKit/ChangeLog

@@ +1 @@
+2019-01-16  Alan Coon  <alancoon@apple.com>
+
+        Cherry-pick r239757. rdar://problem/47260195
+
+    [Mac] Layout Test http/wpt/webauthn/public-key-credential-create-success-hid.https.html and http/wpt/webauthn/public-key-credential-get-success-hid.https.html are flaky
+    https://bugs.webkit.org/show_bug.cgi?id=192061
+    
+    Reviewed by Dewei Zhu.
+    
+    Part 6.
+    
+    Add some additional temporary logging info to determine if data is actually sent.
+    Once the bug is determined and fixed, we should remove all logging added in this patch.
+    
+    * UIProcess/WebAuthentication/Mock/MockHidConnection.cpp:
+    (WebKit::MockHidConnection::send):
+    
+    
+    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239757 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+    2019-01-08  Jiewen Tan  <jiewen_tan@apple.com>
+
+            [Mac] Layout Test http/wpt/webauthn/public-key-credential-create-success-hid.https.html and http/wpt/webauthn/public-key-credential-get-success-hid.https.html are flaky
+            https://bugs.webkit.org/show_bug.cgi?id=192061
+
+            Reviewed by Dewei Zhu.
+
+            Part 6.
+
+            Add some additional temporary logging info to determine if data is actually sent.
+            Once the bug is determined and fixed, we should remove all logging added in this patch.
+
+            * UIProcess/WebAuthentication/Mock/MockHidConnection.cpp:
+            (WebKit::MockHidConnection::send):
+
 2019-01-10  Jiewen Tan  <jiewen_tan@apple.com>
 

branches/safari-607-branch/Source/WebKit/UIProcess/WebAuthentication/Mock/MockHidConnection.cpp

@@ -71 +71 @@
 void MockHidConnection::send(Vector<uint8_t>&& data, DataSentCallback&& callback)
 {
+    // FIXME(192061): Remove all LOG_ERRORs.
+    LOG_ERROR("Sending data: Phase 1. Current time: %f.", MonotonicTime::now().secondsSinceEpoch().value());
     ASSERT(m_initialized);
     auto task = makeBlockPtr([weakThis = makeWeakPtr(*this), data = WTFMove(data), callback = WTFMove(callback)]() mutable {
         ASSERT(!RunLoop::isMain());
+        LOG_ERROR("Sending data: Phase 2. Current time: %f.", MonotonicTime::now().secondsSinceEpoch().value());
         RunLoop::main().dispatch([weakThis, data = WTFMove(data), callback = WTFMove(callback)]() mutable {
+            LOG_ERROR("Sending data: Phase 3. Current time: %f.", MonotonicTime::now().secondsSinceEpoch().value());
             if (!weakThis) {
                 callback(DataSent::No);
@@ -80 +84 @@
             }
 
+            LOG_ERROR("Sending data: Phase 4. Current time: %f.", MonotonicTime::now().secondsSinceEpoch().value());
             weakThis->assembleRequest(WTFMove(data));
 
+            LOG_ERROR("Sending data: Phase 5. Current time: %f.", MonotonicTime::now().secondsSinceEpoch().value());
             auto sent = DataSent::Yes;
             if (weakThis->stagesMatch() && weakThis->m_configuration.hid->error == Mock::Error::DataNotSent)