Changeset 240256 in webkit

Timestamp:

Jan 22, 2019, 10:15:00 AM (8 years ago)

Author:

ddkilzer@apple.com

Message:

Leak of NSMutableArray (128 bytes) in com.apple.WebKit.WebContent running WebKit layout tests
<​https://webkit.org/b/193673>
<rdar://problem/47448241>

Reviewed by Dean Jackson.

• platform/graphics/gpu/cocoa/GPUBindGroupLayoutMetal.mm:

(WebCore::appendArgumentToArray): Use adoptNS() to fix the leak.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/graphics/gpu/cocoa/GPUBindGroupLayoutMetal.mm (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2019-01-22  David Kilzer  <ddkilzer@apple.com>
+
+        Leak of NSMutableArray (128 bytes) in com.apple.WebKit.WebContent running WebKit layout tests
+        <https://webkit.org/b/193673>
+        <rdar://problem/47448241>
+
+        Reviewed by Dean Jackson.
+
+        * platform/graphics/gpu/cocoa/GPUBindGroupLayoutMetal.mm:
+        (WebCore::appendArgumentToArray): Use adoptNS() to fix the leak.
+
 2019-01-22  Zalan Bujtas  <zalan@apple.com>
 

trunk/Source/WebCore/platform/graphics/gpu/cocoa/GPUBindGroupLayoutMetal.mm

@@ -56 +56 @@
     BEGIN_BLOCK_OBJC_EXCEPTIONS;
     if (!array)
-        array = [[NSMutableArray alloc] initWithObjects:argument.get(), nil];
+        array = adoptNS([[NSMutableArray alloc] initWithObjects:argument.get(), nil]);
     else
         [array addObject:argument.get()];