Changeset 240381 in webkit

Timestamp:

Jan 23, 2019, 5:21:35 PM (8 years ago)

Author:

Alan Coon

Message:

Cherry-pick r240051. rdar://problem/47458262

Web Inspector: Fix TreeOutline TypeError:​ this._indexesForSubtree is not a function
​https://bugs.webkit.org/show_bug.cgi?id=193501
<rdar://problem/47323967>

Reviewed by Joseph Pecoraro.

• UserInterface/Views/TreeOutline.js: (WI.TreeOutline.prototype.removeChildAtIndex):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@240051 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Location:

branches/safari-607-branch/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Views/TreeOutline.js (modified) (1 diff)

branches/safari-607-branch/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2019-01-23  Alan Coon  <alancoon@apple.com>
+
+        Cherry-pick r240051. rdar://problem/47458262
+
+    Web Inspector: Fix TreeOutline TypeError:​ this._indexesForSubtree is not a function
+    https://bugs.webkit.org/show_bug.cgi?id=193501
+    <rdar://problem/47323967>
+    
+    Reviewed by Joseph Pecoraro.
+    
+    * UserInterface/Views/TreeOutline.js:
+    (WI.TreeOutline.prototype.removeChildAtIndex):
+    
+    
+    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@240051 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+    2019-01-16  Matt Baker  <mattbaker@apple.com>
+
+            Web Inspector: Fix TreeOutline TypeError:​ this._indexesForSubtree is not a function
+            https://bugs.webkit.org/show_bug.cgi?id=193501
+            <rdar://problem/47323967>
+
+            Reviewed by Joseph Pecoraro.
+
+            * UserInterface/Views/TreeOutline.js:
+            (WI.TreeOutline.prototype.removeChildAtIndex):
+
 2019-01-15  Alan Coon  <alancoon@apple.com>
 

branches/safari-607-branch/Source/WebInspectorUI/UserInterface/Views/TreeOutline.js

@@ -324 +324 @@
         }
 
+        let removedIndexes = null;
+
         let treeOutline = child.treeOutline;
         if (treeOutline) {
             treeOutline._forgetTreeElement(child);
             treeOutline._forgetChildrenRecursive(child);
-        }
-
-        let removedIndexes = this._indexesForSubtree(child);
+            removedIndexes = treeOutline._indexesForSubtree(child);
+        }
 
         if (child.previousSibling)