⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Changeset 240809 in webkit


Ignore:
Timestamp:
Jan 31, 2019, 1:34:34 PM (8 years ago)
Author:
benjamin@webkit.org
Message:

Remove WKPageIsWebProcessResponsive
​https://bugs.webkit.org/show_bug.cgi?id=194096

Reviewed by Alex Christensen.

It is not used by any client.

It is also bad API. It is better to let WebKit track
responsiveness and tell the client with processDidBecomeResponsive.

  • UIProcess/API/C/WKPage.cpp:

(WKPageIsWebProcessResponsive): Deleted.

  • UIProcess/API/C/WKPagePrivate.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::isWebProcessResponsive): Deleted.

  • UIProcess/WebPageProxy.h:
Location:
trunk/Source/WebKit
Files:
5 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebKit/ChangeLog

    r240808 r240809  
     12019-01-31  Benjamin Poulain  <benjamin@webkit.org>
     2
     3        Remove WKPageIsWebProcessResponsive
     4        https://bugs.webkit.org/show_bug.cgi?id=194096
     5
     6        Reviewed by Alex Christensen.
     7
     8        It is not used by any client.
     9
     10        It is also bad API. It is better to let WebKit track
     11        responsiveness and tell the client with processDidBecomeResponsive.
     12
     13        * UIProcess/API/C/WKPage.cpp:
     14        (WKPageIsWebProcessResponsive): Deleted.
     15        * UIProcess/API/C/WKPagePrivate.h:
     16        * UIProcess/WebPageProxy.cpp:
     17        (WebKit::WebPageProxy::isWebProcessResponsive): Deleted.
     18        * UIProcess/WebPageProxy.h:
     19
    1202019-01-31  Alex Christensen  <achristensen@webkit.org>
    221

  • trunk/Source/WebKit/UIProcess/API/C/WKPage.cpp

    r240490 r240809  
    23282328}
    23292329
    2330 void WKPageIsWebProcessResponsive(WKPageRef pageRef, void* context, WKPageIsWebProcessResponsiveFunction callback)
    2331 {
    2332     toImpl(pageRef)->isWebProcessResponsive([context, callback](bool isWebProcessResponsive) {
    2333         callback(isWebProcessResponsive, context);
    2334     });
    2335 }
    2336 
    23372330void WKPageGetSelectionAsWebArchiveData(WKPageRef pageRef, void* context, WKPageGetSelectionAsWebArchiveDataFunction callback)
    23382331{

  • trunk/Source/WebKit/UIProcess/API/C/WKPagePrivate.h

    r239840 r240809  
    104104WK_EXPORT void WKPageGetSamplingProfilerOutput(WKPageRef page, void* context, WKPageGetSamplingProfilerOutputFunction function);
    105105
    106 typedef void (*WKPageIsWebProcessResponsiveFunction)(bool isWebProcessResponsive, void* context);
    107 WK_EXPORT void WKPageIsWebProcessResponsive(WKPageRef page, void* context, WKPageIsWebProcessResponsiveFunction function);
    108    
    109106WK_EXPORT WKArrayRef WKPageCopyRelatedPages(WKPageRef page);
    110107

  • trunk/Source/WebKit/UIProcess/WebPageProxy.cpp

    r240759 r240809  
    35393539}
    35403540
    3541 void WebPageProxy::isWebProcessResponsive(WTF::Function<void (bool isWebProcessResponsive)>&& callbackFunction)
    3542 {
    3543     if (!isValid()) {
    3544         RunLoop::main().dispatch([callbackFunction = WTFMove(callbackFunction)] {
    3545             bool isWebProcessResponsive = true;
    3546             callbackFunction(isWebProcessResponsive);
    3547         });
    3548         return;
    3549     }
    3550 
    3551     m_process->isResponsive(WTFMove(callbackFunction));
    3552 }
    3553 
    35543541#if ENABLE(MHTML)
    35553542void WebPageProxy::getContentsAsMHTMLData(Function<void (API::Data*, CallbackBase::Error)>&& callbackFunction)

  • trunk/Source/WebKit/UIProcess/WebPageProxy.h

    r240712 r240809  
    946946    void getBytecodeProfile(WTF::Function<void (const String&, CallbackBase::Error)>&&);
    947947    void getSamplingProfilerOutput(WTF::Function<void (const String&, CallbackBase::Error)>&&);
    948     void isWebProcessResponsive(WTF::Function<void (bool isWebProcessResponsive)>&&);
    949948
    950949#if ENABLE(MHTML)
Note: See TracChangeset for help on using the changeset viewer.