Changeset 240862 in webkit

Timestamp:

Feb 1, 2019, 12:20:26 PM (8 years ago)

Author:

Simon Fraser

Message:

Force settings.acceleratedCompositingEnabled() to true for WebKit
​https://bugs.webkit.org/show_bug.cgi?id=194166
rdar://problem/47694328

Reviewed by Tim Horton.

WebKit relies on accelerated compositing for its drawing areas to function correctly,
and sometimes clients (*cough* Safari *cough*) have bugs where they clobber the settings,
so force this setting to be always on (and release log if this happens).

• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• WebProcess/WebPage/WebPage.cpp (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2019-02-01  Simon Fraser  <simon.fraser@apple.com>
+
+        Force settings.acceleratedCompositingEnabled() to true for WebKit
+        https://bugs.webkit.org/show_bug.cgi?id=194166
+        rdar://problem/47694328
+
+        Reviewed by Tim Horton.
+
+        WebKit relies on accelerated compositing for its drawing areas to function correctly,
+        and sometimes clients (*cough* Safari *cough*) have bugs where they clobber the settings,
+        so force this setting to be always on (and release log if this happens).
+
+        * WebProcess/WebPage/WebPage.cpp:
+        (WebKit::WebPage::updatePreferences):
+
 2019-02-01  Antti Koivisto  <antti@apple.com>
 

trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp

@@ -3366 +3366 @@
     Settings& settings = m_page->settings();
 
+    if (!settings.acceleratedCompositingEnabled()) {
+        RELEASE_LOG_IF_ALLOWED("%p - WebPage - acceleratedCompositingEnabled setting was false. WebKit cannot function in this mode; changing setting to true", this);
+        settings.setAcceleratedCompositingEnabled(true);
+    }
+
     bool requiresUserGestureForMedia = store.getBoolValueForKey(WebPreferencesKey::requiresUserGestureForMediaPlaybackKey());
     settings.setVideoPlaybackRequiresUserGesture(requiresUserGestureForMedia || store.getBoolValueForKey(WebPreferencesKey::requiresUserGestureForVideoPlaybackKey()));