Changeset 240866 in webkit

Timestamp:

Feb 1, 2019 1:24:09 PM (5 years ago)

Author:

Joseph Pecoraro

Message:

Web Inspector: Timeline time range selection should show duration alongside start and end
​https://bugs.webkit.org/show_bug.cgi?id=194109
<rdar://problem/47714279>

Reviewed by Devin Rousso.

• Localizations/en.lproj/localizedStrings.js:
• UserInterface/Views/TimelineRecordingContentView.js:

(WI.TimelineRecordingContentView.prototype._updateTimeRangePathComponents):
Include the duration when not obvious.

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• Localizations/en.lproj/localizedStrings.js (modified) (1 diff)
• UserInterface/Views/TimelineRecordingContentView.js (modified) (1 diff)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2019-02-01  Joseph Pecoraro  <pecoraro@apple.com>
+
+        Web Inspector: Timeline time range selection should show duration alongside start and end
+        https://bugs.webkit.org/show_bug.cgi?id=194109
+        <rdar://problem/47714279>
+
+        Reviewed by Devin Rousso.
+
+        * Localizations/en.lproj/localizedStrings.js:
+        * UserInterface/Views/TimelineRecordingContentView.js:
+        (WI.TimelineRecordingContentView.prototype._updateTimeRangePathComponents):
+        Include the duration when not obvious.
+
 2019-02-01  Joseph Pecoraro  <pecoraro@apple.com>
 

trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js

@@ -55 +55 @@
 localizedStrings["%s Result"] = "%s Result";
 localizedStrings["%s \u2013 %s"] = "%s \u2013 %s";
+localizedStrings["%s \u2013 %s (%s)"] = "%s \u2013 %s (%s)";
 localizedStrings["%s \u2014 %s"] = "%s \u2014 %s";
 localizedStrings["%s cannot be modified"] = "%s cannot be modified";

trunk/Source/WebInspectorUI/UserInterface/Views/TimelineRecordingContentView.js

@@ -730 +730 @@
         let displayName;
         if (this._timelineOverview.viewMode === WI.TimelineOverview.ViewMode.Timelines) {
-            let selectionStart = Number.secondsToString(startValue, true);
-            let selectionEnd = Number.secondsToString(endValue, true);
-            displayName = WI.UIString("%s \u2013 %s").format(selectionStart, selectionEnd);
+            const higherResolution = true;
+            let selectionStart = Number.secondsToString(startValue, higherResolution);
+            let selectionEnd = Number.secondsToString(endValue, higherResolution);
+            const epsilon = 0.0001;
+            if (startValue < epsilon)
+                displayName = WI.UIString("%s \u2013 %s").format(selectionStart, selectionEnd);
+            else {
+                let duration = Number.secondsToString(endValue - startValue, higherResolution);
+                displayName = WI.UIString("%s \u2013 %s (%s)").format(selectionStart, selectionEnd, duration);
+            }
         } else {
             startValue += 1; // Convert index to frame number.