Changeset 24091 in webkit


Ignore:
Timestamp:
Jul 7, 2007 1:42:50 PM (17 years ago)
Author:
darin
Message:

LayoutTests:

  • test for <rdar://problem/5292364> REGRESSION: ZX Spectrum 3.0 widget - graphic anomalies in widget window frame
  • fast/canvas/fill-stroke-clip-reset-path-expected.checksum: Added.
  • fast/canvas/fill-stroke-clip-reset-path-expected.png: Added.
  • fast/canvas/fill-stroke-clip-reset-path-expected.txt: Added.
  • fast/canvas/fill-stroke-clip-reset-path.html: Added.

WebCore:

Reviewed by Oliver Hunt.

  • fix <rdar://problem/5292364> REGRESSION: ZX Spectrum 3.0 widget - graphic anomalies in widget window frame

Updated Dashboard quirk so it affects fill, stroke, and clip, rather than just stroke.

Test: fast/canvas/fill-stroke-clip-reset-path.html

  • html/CanvasRenderingContext2D.h: Added clearPathForDashboardBackwardCompatibilityMode.
  • html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::clearPathForDashboardBackwardCompatibilityMode): Added. (WebCore::CanvasRenderingContext2D::fill): Call the new function. (WebCore::CanvasRenderingContext2D::stroke): Replaced in-line code with a call to the new function. (WebCore::CanvasRenderingContext2D::clip): Call the new function.
Location:
trunk
Files:
4 added
4 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r24090 r24091  
     12007-07-07  Darin Adler  <darin@apple.com>
     2
     3        - test for <rdar://problem/5292364> REGRESSION: ZX Spectrum 3.0 widget - graphic anomalies in widget window frame
     4
     5        * fast/canvas/fill-stroke-clip-reset-path-expected.checksum: Added.
     6        * fast/canvas/fill-stroke-clip-reset-path-expected.png: Added.
     7        * fast/canvas/fill-stroke-clip-reset-path-expected.txt: Added.
     8        * fast/canvas/fill-stroke-clip-reset-path.html: Added.
     9
    1102007-07-07  Rob Buis  <buis@kde.org>
    211

  • trunk/WebCore/ChangeLog

    r24090 r24091  
     12007-07-07  Darin Adler  <darin@apple.com>
     2
     3        Reviewed by Oliver Hunt.
     4
     5        - fix <rdar://problem/5292364> REGRESSION: ZX Spectrum 3.0 widget - graphic anomalies in widget window frame
     6
     7        Updated Dashboard quirk so it affects fill, stroke, and clip, rather than just stroke.
     8
     9        Test: fast/canvas/fill-stroke-clip-reset-path.html
     10
     11        * html/CanvasRenderingContext2D.h: Added clearPathForDashboardBackwardCompatibilityMode.
     12        * html/CanvasRenderingContext2D.cpp:
     13        (WebCore::CanvasRenderingContext2D::clearPathForDashboardBackwardCompatibilityMode): Added.
     14        (WebCore::CanvasRenderingContext2D::fill): Call the new function.
     15        (WebCore::CanvasRenderingContext2D::stroke): Replaced in-line code with a call to the new function.
     16        (WebCore::CanvasRenderingContext2D::clip): Call the new function.
     17
    1182007-07-07  Rob Buis  <buis@kde.org>
    219

  • trunk/WebCore/html/CanvasRenderingContext2D.cpp

    r24090 r24091  
    11/*
    2  * Copyright (C) 2004, 2005, 2006 Apple Computer, Inc. All rights reserved.
     2 * Copyright (C) 2004, 2005, 2006, 2007 Apple Inc. All rights reserved.
    33 * Copyright (C) 2007 Trolltech ASA
    44 *
    … …  
    431431}
    432432
     433void CanvasRenderingContext2D::clearPathForDashboardBackwardCompatibilityMode()
     434{
     435    if (m_canvas)
     436        if (Settings* settings = m_canvas->document()->settings())
     437            if (settings->usesDashboardBackwardCompatibilityMode())
     438                state().m_path.clear();
     439}
     440
    433441void CanvasRenderingContext2D::fill()
    434442{
    … …  
    468476    }
    469477#endif
     478
     479    clearPathForDashboardBackwardCompatibilityMode();
    470480}
    471481
    … …  
    513523#endif
    514524
    515     Settings* settings = m_canvas ? m_canvas->document()->settings() : 0;
    516     if (settings && settings->usesDashboardBackwardCompatibilityMode())
    517         state().m_path.clear();
     525    clearPathForDashboardBackwardCompatibilityMode();
    518526}
    519527
    … …  
    524532        return;
    525533    c->clip(state().m_path);
     534    clearPathForDashboardBackwardCompatibilityMode();
    526535}
    527536

  • trunk/WebCore/html/CanvasRenderingContext2D.h

    r18874 r24091  
    11/*
    2  * Copyright (C) 2006 Apple Computer, Inc. All rights reserved.
     2 * Copyright (C) 2006, 2007 Apple Inc. All rights reserved.
    33 *
    44 * Redistribution and use in source and binary forms, with or without
    … …  
    200200        void applyFillPattern();
    201201
     202        void clearPathForDashboardBackwardCompatibilityMode();
     203
    202204        HTMLCanvasElement* m_canvas;
    203205        Vector<State, 1> m_stateStack;
Note: See TracChangeset for help on using the changeset viewer.