Changeset 241307 in webkit

Timestamp:

Feb 12, 2019, 11:51:02 AM (8 years ago)

Author:

Chris Fleizach

Message:

AX: Fix flaky accessibility/loading-iframe-sends-notification.html
​https://bugs.webkit.org/show_bug.cgi?id=194546

Reviewed by Zalan Bujtas.

This test was relying on timing between load events being sent and accessibility events being sent.
We don't need to do that, we can more directly test this interplay.

• accessibility/loading-iframe-sends-notification-expected.txt:
• accessibility/loading-iframe-sends-notification.html:

Location:

trunk/LayoutTests

Files:

• ChangeLog (modified) (1 diff)
• accessibility/loading-iframe-sends-notification-expected.txt (modified) (1 diff)
• accessibility/loading-iframe-sends-notification.html (modified) (2 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2019-02-12  Chris Fleizach  <cfleizach@apple.com>
+
+        AX: Fix flaky accessibility/loading-iframe-sends-notification.html
+        https://bugs.webkit.org/show_bug.cgi?id=194546
+
+        Reviewed by Zalan Bujtas.
+
+        This test was relying on timing between load events being sent and accessibility events being sent.
+        We don't need to do that, we can more directly test this interplay.
+
+        * accessibility/loading-iframe-sends-notification-expected.txt:
+        * accessibility/loading-iframe-sends-notification.html:
+
 2019-02-12  Adrian Perez de Castro  <aperez@igalia.com>
 

trunk/LayoutTests/accessibility/loading-iframe-sends-notification-expected.txt

@@ -14 +14 @@
 Got notification on iframe.
 PASS findByAccessibleTitleSubstring(root, 'InnerButton') != null is true
-PASS gotIframeNotification is true
 PASS successfullyParsed is true
 

trunk/LayoutTests/accessibility/loading-iframe-sends-notification.html

@@ -43 +43 @@
     function runTest()
     {
-        window.gotIframeNotification = false;
-
         if (window.accessibilityController) {
             window.root = accessibilityController.rootElement;
@@ -60 +58 @@
 
                 debug("Got notification on iframe.");
-                gotIframeNotification = true;
 
                 // Check that the button within the iframe is now reachable from the root.
                 shouldBeTrue("findByAccessibleTitleSubstring(root, 'InnerButton') != null");
+                accessibilityController.removeNotificationListener();
+                finishJSTest();
             });
         }
 
         window.iframeElement = document.getElementById("iframe");
-        iframeElement.addEventListener("load", function() {
-            window.setTimeout(function() {
-                shouldBeTrue("gotIframeNotification");
-                if (window.accessibilityController)
-                    accessibilityController.removeNotificationListener();
-
-                finishJSTest();
-            }, 10);
-        }, false);
 
         // Load content into the iframe. This will trigger the event