Changeset 241632 in webkit

Timestamp:

Feb 15, 2019, 4:36:06 PM (8 years ago)

Author:

Chris Dumez

Message:

Sample domainsVisited diagnostic logging
​https://bugs.webkit.org/show_bug.cgi?id=194657

Reviewed by Ryosuke Niwa.

Sample domainsVisited diagnostic logging, we are getting a lot of data from
this key and this is hurting our other keys.

• page/Page.cpp:

(WebCore::Page::logNavigation):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• page/Page.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2019-02-15  Chris Dumez  <cdumez@apple.com>
+
+        Sample domainsVisited diagnostic logging
+        https://bugs.webkit.org/show_bug.cgi?id=194657
+
+        Reviewed by Ryosuke Niwa.
+
+        Sample domainsVisited diagnostic logging, we are getting a lot of data from
+        this key and this is hurting our other keys.
+
+        * page/Page.cpp:
+        (WebCore::Page::logNavigation):
+
 2019-02-15  Ryosuke Niwa  <rniwa@webkit.org>
 

trunk/Source/WebCore/page/Page.cpp

@@ -2370 +2370 @@
 
     if (!navigation.domain.isEmpty())
-        diagnosticLoggingClient().logDiagnosticMessageWithEnhancedPrivacy(DiagnosticLoggingKeys::domainVisitedKey(), navigation.domain, ShouldSample::No);
+        diagnosticLoggingClient().logDiagnosticMessageWithEnhancedPrivacy(DiagnosticLoggingKeys::domainVisitedKey(), navigation.domain, ShouldSample::Yes);
 }