Changeset 241754 in webkit

Timestamp:

Feb 18, 2019, 7:03:02 PM (7 years ago)

Author:

achristensen@apple.com

Message:

Revert functional part of r241451
​https://bugs.webkit.org/show_bug.cgi?id=194510

Source/WebKit:

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didFinishDocumentLoadForFrame):
It caused crashes and assertions on Linux and Cocoa without safe browsing, which
means it's fundamentally flawed in some way. The testing piping was fine.

LayoutTests:

• platform/wk2/TestExpectations:

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/platform/wk2/TestExpectations (modified) (1 diff)
• Source/WebKit/ChangeLog (modified) (1 diff)
• Source/WebKit/UIProcess/WebPageProxy.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2019-02-18  Alex Christensen  <achristensen@webkit.org>
+
+        Revert functional part of r241451
+        https://bugs.webkit.org/show_bug.cgi?id=194510
+
+        * platform/wk2/TestExpectations:
+
 2019-02-18  Daniel Bates  <dabates@apple.com>
 

trunk/LayoutTests/platform/wk2/TestExpectations

@@ -750 +750 @@
 fast/forms/call-text-did-change-in-text-field-when-typing.html [ Pass ]
 
-http/tests/adClickAttribution [ Pass ]
+http/tests/adClickAttribution [ Failure ]
 
 ### END OF (5) Progressions, expected successes that are expected failures in WebKit1.

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2019-02-18  Alex Christensen  <achristensen@webkit.org>
+
+        Revert functional part of r241451
+        https://bugs.webkit.org/show_bug.cgi?id=194510
+
+        * UIProcess/WebPageProxy.cpp:
+        (WebKit::WebPageProxy::didFinishDocumentLoadForFrame):
+        It caused crashes and assertions on Linux and Cocoa without safe browsing, which
+        means it's fundamentally flawed in some way.  The testing piping was fine.
+
 2019-02-18  Chris Dumez  <cdumez@apple.com>
 

trunk/Source/WebKit/UIProcess/WebPageProxy.cpp

@@ -4145 +4145 @@
     // FIXME: We should message check that navigationID is not zero here, but it's currently zero for some navigations through the page cache.
     RefPtr<API::Navigation> navigation;
-    if (frame->isMainFrame() && navigationID) {
+    if (frame->isMainFrame() && navigationID)
         navigation = navigationState().navigation(navigationID);
-        if (navigation) {
-            if (auto& adClickAttribution = navigation->adClickAttribution()) {
-                if (adClickAttribution->destination().matches(frame->url()))
-                    m_process->processPool().sendToNetworkingProcess(Messages::NetworkProcess::StoreAdClickAttribution(m_websiteDataStore->sessionID(), *adClickAttribution));
-            }
-        }
-    }
 
     if (frame->isMainFrame())