Changeset 242078 in webkit

Timestamp:

Feb 26, 2019, 12:00:26 AM (8 years ago)

Author:

Devin Rousso

Message:

Web Inspector: Console: dragging a selection outside the selected element clears the selection
​https://bugs.webkit.org/show_bug.cgi?id=194660
<rdar://problem/46719239>

Reviewed by Joseph Pecoraro.

• UserInterface/Views/LogContentView.js:

(WI.LogContentView.prototype._mousemove):
Don't clear the selection if the target of the "mousemove" is outside of the view.

(WI.LogContentView.prototype._updateMessagesSelection):
Drive-by: clear the saved selected messages when we're just selecting a single message.

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Views/LogContentView.js (modified) (3 diffs)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2019-02-26  Devin Rousso  <drousso@apple.com>
+
+        Web Inspector: Console: dragging a selection outside the selected element clears the selection
+        https://bugs.webkit.org/show_bug.cgi?id=194660
+        <rdar://problem/46719239>
+
+        Reviewed by Joseph Pecoraro.
+
+        * UserInterface/Views/LogContentView.js:
+        (WI.LogContentView.prototype._mousemove):
+        Don't clear the selection if the target of the "mousemove" is outside of the view.
+
+        (WI.LogContentView.prototype._updateMessagesSelection):
+        Drive-by: clear the saved selected messages when we're just selecting a single message.
+
 2019-02-25  Joseph Pecoraro  <pecoraro@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/Views/LogContentView.js

@@ -533 +533 @@
         if (!wrapper) {
             // No wrapper under the mouse, so look at the selection to try and find one.
-            if (!selection.isCollapsed) {
-                wrapper = selection.focusNode.parentNode.enclosingNodeOrSelfWithClass(WI.LogContentView.ItemWrapperStyleClassName);
+            if (!selection.isCollapsed)
+                wrapper = selection.focusNode.enclosingNodeOrSelfWithClass(WI.LogContentView.ItemWrapperStyleClassName);
+
+            if (!wrapper) {
                 selection.removeAllRanges();
+                return;
             }
-
-            if (!wrapper)
-                return;
         }
 
@@ -546 +546 @@
 
         if (wrapper === this._mouseDownWrapper && !this._mouseMoveIsRowSelection)
+            return;
+
+        // Don't change the selection if the mouse has moved outside of the view (e.g. for faster scrolling).
+        if (!this.element.contains(event.target))
             return;
 
@@ -658 +662 @@
             message.classList.add(WI.LogContentView.SelectedStyleClassName);
             this._selectedMessages.push(message);
+            this._selectionRange = null;
         }