Changeset 242376 in webkit

Timestamp:

Mar 4, 2019, 12:39:33 PM (7 years ago)

Author:

beidson@apple.com

Message:

Correctly handle sandbox extensions when the same WKWebView loads multiple ​file:// URLs.
<rdar://problem/47820581> and ​https://bugs.webkit.org/show_bug.cgi?id=195291

Reviewed by Andy Estes.

• WebProcess/WebPage/WebPage.cpp:

(WebKit::shouldReuseCommittedSandboxExtension): Only retain the previous sandbox extension if the file URL

we're currently loading is functionally equivalent to the previous one.

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• WebProcess/WebPage/WebPage.cpp (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2019-03-04  Brady Eidson  <beidson@apple.com>
+
+        Correctly handle sandbox extensions when the same WKWebView loads multiple file:// URLs.
+        <rdar://problem/47820581> and https://bugs.webkit.org/show_bug.cgi?id=195291
+
+        Reviewed by Andy Estes.
+
+        * WebProcess/WebPage/WebPage.cpp:
+        (WebKit::shouldReuseCommittedSandboxExtension): Only retain the previous sandbox extension if the file URL
+          we're currently loading is functionally equivalent to the previous one.
+
 2019-03-04  Chris Dumez  <cdumez@apple.com>
 

trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp

@@ -4413 +4413 @@
         return false;
 
-    if (documentLoader->url().isLocalFile() && provisionalDocumentLoader->url().isLocalFile())
+    if (documentLoader->url().isLocalFile() && provisionalDocumentLoader->url().isLocalFile() && equalIgnoringQueryAndFragment(documentLoader->url(), provisionalDocumentLoader->url()))
         return true;