Changeset 242566 in webkit

Timestamp:

Mar 6, 2019 2:28:27 PM (5 years ago)

Author:

Joseph Pecoraro

Message:

Web Inspector: TimelineOverview clicks do not always behave as expected
​https://bugs.webkit.org/show_bug.cgi?id=195319

Reviewed by Devin Rousso.

• UserInterface/Views/TimelineRuler.js:

(WI.TimelineRuler.prototype._shouldIgnoreMicroMovement):
(WI.TimelineRuler.prototype._handleMouseDown):
(WI.TimelineRuler.prototype._handleMouseMove):
Ignore moves that haven't gone more than 4px. Once the threshold is
passed allow all moves. This improves the click behavior since
previously click would never re-dispatch if there was any movement.

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Views/TimelineRuler.js (modified) (3 diffs)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2019-03-06  Joseph Pecoraro  <pecoraro@apple.com>
+
+        Web Inspector: TimelineOverview clicks do not always behave as expected
+        https://bugs.webkit.org/show_bug.cgi?id=195319
+
+        Reviewed by Devin Rousso.
+
+        * UserInterface/Views/TimelineRuler.js:
+        (WI.TimelineRuler.prototype._shouldIgnoreMicroMovement):
+        (WI.TimelineRuler.prototype._handleMouseDown):
+        (WI.TimelineRuler.prototype._handleMouseMove):
+        Ignore moves that haven't gone more than 4px. Once the threshold is
+        passed allow all moves. This improves the click behavior since
+        previously click would never re-dispatch if there was any movement.
+
 2019-03-06  Joseph Pecoraro  <pecoraro@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/Views/TimelineRuler.js

@@ -747 +747 @@
     }
 
+    _shouldIgnoreMicroMovement(event)
+    {
+        if (this._mousePassedMicroMovementTest)
+            return false;
+
+        let pixels = Math.abs(event.pageX - this._mouseStartX);
+        if (pixels <= 4)
+            return true;
+
+        this._mousePassedMicroMovementTest = true;
+        return false;
+    }
+
     _handleClick(event)
     {
@@ -798 +811 @@
         this._mouseMoved = false;
 
+        this._mousePassedMicroMovementTest = false;
+        this._mouseStartX = event.pageX;
+
         this._mouseMoveEventListener = this._handleMouseMove.bind(this);
         this._mouseUpEventListener = this._handleMouseUp.bind(this);
@@ -812 +828 @@
     {
         console.assert(event.button === 0);
+
+        if (this._shouldIgnoreMicroMovement(event))
+            return;
 
         this._mouseMoved = true;