Changeset 242629 in webkit

Timestamp:

Mar 7, 2019, 7:26:38 PM (7 years ago)

Author:

timothy_horton@apple.com

Message:

Crash under RemoteLayerTreePropertyApplier::applyProperties
​https://bugs.webkit.org/show_bug.cgi?id=195448
<rdar://problem/48588226>

Reviewed by Simon Fraser.

• UIProcess/RemoteLayerTree/RemoteLayerTreeHost.mm:

(WebKit::RemoteLayerTreeHost::updateLayerTree):
Under some currently-unknown circumstances, the UI process is receiving
commits referring to layers that it does not know about.
One understood case of this was fixed in r241899, but there seem to be
cases remaining that are not understood.
Also, add a release log so that we can identify any downstream effects.

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/RemoteLayerTree/RemoteLayerTreeHost.mm (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2019-03-07  Tim Horton  <timothy_horton@apple.com>
+
+        Crash under RemoteLayerTreePropertyApplier::applyProperties
+        https://bugs.webkit.org/show_bug.cgi?id=195448
+        <rdar://problem/48588226>
+
+        Reviewed by Simon Fraser.
+
+        * UIProcess/RemoteLayerTree/RemoteLayerTreeHost.mm:
+        (WebKit::RemoteLayerTreeHost::updateLayerTree):
+        Under some currently-unknown circumstances, the UI process is receiving
+        commits referring to layers that it does not know about.
+        One understood case of this was fixed in r241899, but there seem to be
+        cases remaining that are not understood.
+        Also, add a release log so that we can identify any downstream effects.
+
 2019-03-07  Zalan Bujtas  <zalan@apple.com>
 

trunk/Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeHost.mm

@@ -103 +103 @@
         ASSERT(node);
 
+        if (!node) {
+            // We have evidence that this can still happen, but don't know how (see r241899 for one already-fixed cause).
+            RELEASE_LOG_IF_ALLOWED("%p RemoteLayerTreeHost::updateLayerTree - failed to find layer with ID %llu", this, layerID);
+            continue;
+        }
+
         if (properties.changedProperties.contains(RemoteLayerTreeTransaction::ClonedContentsChanged) && properties.clonedLayerID)
             clonesToUpdate.append({ layerID, properties.clonedLayerID });