Changeset 242656 in webkit

Timestamp:

Mar 8, 2019, 2:12:46 PM (7 years ago)

Author:

Alan Bujtas

Message:

[ContentChangeObserver] Cleanup adjustObservedState
​https://bugs.webkit.org/show_bug.cgi?id=195470
<rdar://problem/48717823>

Reviewed by Simon Fraser.

This is in preparation for introducing an observation window from touchStart -> mouseMoved.

1. Cancel pending activities (future timers, pending stylesheet recalcs) when visible content change is detected.
2. The fixed time window takes care of notifying the client -timers, style recalcs during the window should not signal themselves.
3. Reset m_isObservingPendingStyleRecalc at StartedStyleRecalc instead of EndedStyleRecalc.

• page/ios/ContentChangeObserver.cpp:

(WebCore::ContentChangeObserver::domTimerExecuteDidFinish):
(WebCore::ContentChangeObserver::styleRecalcDidStart):
(WebCore::ContentChangeObserver::styleRecalcDidFinish):
(WebCore::ContentChangeObserver::adjustObservedState):

• page/ios/ContentChangeObserver.h:

(WebCore::ContentChangeObserver::hasPendingActivity const):
(WebCore::ContentChangeObserver::isObservationTimeWindowActive const):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• page/ios/ContentChangeObserver.cpp (modified) (7 diffs)
• page/ios/ContentChangeObserver.h (modified) (3 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2019-03-08  Zalan Bujtas  <zalan@apple.com>
+
+        [ContentChangeObserver] Cleanup adjustObservedState
+        https://bugs.webkit.org/show_bug.cgi?id=195470
+        <rdar://problem/48717823>
+
+        Reviewed by Simon Fraser.
+
+        This is in preparation for introducing an observation window from touchStart -> mouseMoved.
+        1. Cancel pending activities (future timers, pending stylesheet recalcs) when visible content change is detected.
+        2. The fixed time window takes care of notifying the client -timers, style recalcs during the window should not signal themselves.  
+        3. Reset m_isObservingPendingStyleRecalc at StartedStyleRecalc instead of EndedStyleRecalc. 
+
+        * page/ios/ContentChangeObserver.cpp:
+        (WebCore::ContentChangeObserver::domTimerExecuteDidFinish):
+        (WebCore::ContentChangeObserver::styleRecalcDidStart):
+        (WebCore::ContentChangeObserver::styleRecalcDidFinish):
+        (WebCore::ContentChangeObserver::adjustObservedState):
+        * page/ios/ContentChangeObserver.h:
+        (WebCore::ContentChangeObserver::hasPendingActivity const):
+        (WebCore::ContentChangeObserver::isObservationTimeWindowActive const):
+
 2019-03-08  Zalan Bujtas  <zalan@apple.com>
 

trunk/Source/WebCore/page/ios/ContentChangeObserver.cpp

@@ -94 +94 @@
     LOG_WITH_STREAM(ContentObservation, stream << "startObservingDOMTimerExecute: start observing (" << &timer << ") timer callback.");
 
-    m_domTimerIsBeingExecuted = true;
+    m_observedDomTimerIsBeingExecuted = true;
     adjustObservedState(Event::StartedDOMTimerExecution);
 }
@@ -100 +100 @@
 void ContentChangeObserver::domTimerExecuteDidFinish(const DOMTimer& timer)
 {
-    if (!containsObservedDOMTimer(timer))
+    if (!m_observedDomTimerIsBeingExecuted)
         return;
     LOG_WITH_STREAM(ContentObservation, stream << "stopObservingDOMTimerExecute: stop observing (" << &timer << ") timer callback.");
 
-    m_domTimerIsBeingExecuted = false;
+    m_observedDomTimerIsBeingExecuted = false;
     unregisterDOMTimer(timer);
-    setShouldObserveNextStyleRecalc(m_document.hasPendingStyleRecalc());
     adjustObservedState(Event::EndedDOMTimerExecution);
 }
@@ -114 +113 @@
     if (!isWaitingForStyleRecalc())
         return;
-    if (hasVisibleChangeState())
-        return;
     LOG(ContentObservation, "startObservingStyleRecalc: start observing style recalc.");
 
-    m_styleRecalcIsBeingExecuted = true;
+    m_isInObservedStyleRecalc = true;
     adjustObservedState(Event::StartedStyleRecalc);
 }
@@ -124 +121 @@
 void ContentChangeObserver::styleRecalcDidFinish()
 {
-    if (!isWaitingForStyleRecalc())
+    if (!m_isInObservedStyleRecalc)
         return;
     LOG(ContentObservation, "stopObservingStyleRecalc: stop observing style recalc");
 
-    m_styleRecalcIsBeingExecuted = false;
+    m_isInObservedStyleRecalc = false;
     adjustObservedState(Event::EndedStyleRecalc);
 }
@@ -230 +227 @@
 void ContentChangeObserver::adjustObservedState(Event event)
 {
-    auto notifyContentChangeIfNeeded = [&] {
+    auto adjustStateAndNotifyContentChangeIfNeeded = [&] {
+        // Demote to "no change" when there's no pending activity anymore.
+        if (observedContentChange() == WKContentIndeterminateChange && !hasPendingActivity())
+            setHasNoChangeState();
+
         if (!hasDeterminateState()) {
             LOG(ContentObservation, "notifyContentChangeIfNeeded: not in a determined state yet.");
@@ -249 +250 @@
         setShouldObserveDOMTimerScheduling(true);
         break;
+    case Event::EndedTouchStartEventDispatching:
+        setShouldObserveDOMTimerScheduling(false);
+        break;
     case Event::StartedMouseMovedEventDispatching:
         ASSERT(!m_document.hasPendingStyleRecalc());
@@ -258 +262 @@
         m_isMouseMovedPrecededByTouch = false;
         break;
-    case Event::StartedDOMTimerExecution:
-    case Event::StartedStyleRecalc:
-        ASSERT(observedContentChange() == WKContentIndeterminateChange);
-        break;
-    case Event::EndedTouchStartEventDispatching:
     case Event::EndedMouseMovedEventDispatching:
         setShouldObserveDOMTimerScheduling(false);
         break;
+    case Event::StartedStyleRecalc:
+        setShouldObserveNextStyleRecalc(false);
+        FALLTHROUGH;
+    case Event::StartedDOMTimerExecution:
+        ASSERT(isObservationTimeWindowActive() || observedContentChange() == WKContentIndeterminateChange);
+        break;
     case Event::InstalledDOMTimer:
     case Event::StartedFixedObservationTimeWindow:
-        // Expecting a timer fire. Promote to an indeterminate state.
         ASSERT(!hasVisibleChangeState());
         setHasIndeterminateState();
         break;
+    case Event::EndedDOMTimerExecution:
+        setShouldObserveNextStyleRecalc(m_document.hasPendingStyleRecalc());
+        FALLTHROUGH;
     case Event::EndedStyleRecalc:
-        setShouldObserveNextStyleRecalc(false);
-        FALLTHROUGH;
     case Event::RemovedDOMTimer:
-    case Event::EndedDOMTimerExecution:
+        if (!isObservationTimeWindowActive())
+            adjustStateAndNotifyContentChangeIfNeeded();
+        break;
     case Event::EndedFixedObservationTimeWindow:
-        // Demote to "no change" when there's no pending activity anymore.
-        if (observedContentChange() == WKContentIndeterminateChange && !hasPendingActivity())
-            setHasNoChangeState();
-        notifyContentChangeIfNeeded();
+        adjustStateAndNotifyContentChangeIfNeeded();
         break;
     case Event::ContentVisibilityChanged:
         setHasVisibleChangeState();
+        // Remove pending activities. We don't need to observe them anymore.
+        setShouldObserveNextStyleRecalc(false);
+        clearObservedDOMTimers();
         break;
     }

trunk/Source/WebCore/page/ios/ContentChangeObserver.h

@@ -120 +120 @@
     bool isWaitingForStyleRecalc() const { return m_isWaitingForStyleRecalc; }
 
-    bool isObservingContentChanges() const { return m_mouseMovedEventIsBeingDispatched || m_touchEventIsBeingDispatched || m_domTimerIsBeingExecuted || m_styleRecalcIsBeingExecuted || m_contentObservationTimer.isActive(); }
+    bool isObservingContentChanges() const { return m_mouseMovedEventIsBeingDispatched || m_touchEventIsBeingDispatched || m_observedDomTimerIsBeingExecuted || m_isInObservedStyleRecalc || m_contentObservationTimer.isActive(); }
 
     void cancelPendingActivities();
@@ -132 +132 @@
     bool hasDeterminateState() const;
 
-    bool hasPendingActivity() const { return hasObservedDOMTimer() || m_document.hasPendingStyleRecalc() || m_contentObservationTimer.isActive(); }
+    bool hasPendingActivity() const { return hasObservedDOMTimer() || m_document.hasPendingStyleRecalc() || isObservationTimeWindowActive(); }
+    bool isObservationTimeWindowActive() const { return m_contentObservationTimer.isActive(); }
 #if !ASSERT_DISABLED
     bool isNotifyContentChangeAllowed() const;
@@ -161 +162 @@
     bool m_touchEventIsBeingDispatched { false };
     bool m_isWaitingForStyleRecalc { false };
-    bool m_styleRecalcIsBeingExecuted { false };
+    bool m_isInObservedStyleRecalc { false };
     bool m_isObservingDOMTimerScheduling { false };
-    bool m_domTimerIsBeingExecuted { false };
+    bool m_observedDomTimerIsBeingExecuted { false };
     bool m_isMouseMovedPrecededByTouch { false };
     bool m_mouseMovedEventIsBeingDispatched { false };