Changeset 242659 in webkit

Timestamp:

Mar 8, 2019, 3:24:25 PM (7 years ago)

Author:

rmorisset@apple.com

Message:

GetByIdStatus can be shrunk by 16 bytes
​https://bugs.webkit.org/show_bug.cgi?id=195480

Reviewed by Saam Barati.

8 bytes from reordering fields
8 more bytes by making the enum State only use 1 byte.

• bytecode/GetByIdStatus.cpp:

(JSC::GetByIdStatus::GetByIdStatus):

• bytecode/GetByIdStatus.h:

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• bytecode/GetByIdStatus.cpp (modified) (1 diff)
• bytecode/GetByIdStatus.h (modified) (2 diffs)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2019-03-08  Robin Morisset  <rmorisset@apple.com>
+
+        GetByIdStatus can be shrunk by 16 bytes
+        https://bugs.webkit.org/show_bug.cgi?id=195480
+
+        Reviewed by Saam Barati.
+
+        8 bytes from reordering fields
+        8 more bytes by making the enum State only use 1 byte.
+
+        * bytecode/GetByIdStatus.cpp:
+        (JSC::GetByIdStatus::GetByIdStatus):
+        * bytecode/GetByIdStatus.h:
+
 2019-03-08  Robin Morisset  <rmorisset@apple.com>
 

trunk/Source/JavaScriptCore/bytecode/GetByIdStatus.cpp

@@ -143 +143 @@
 #if ENABLE(JIT)
 GetByIdStatus::GetByIdStatus(const ModuleNamespaceAccessCase& accessCase)
-    : m_state(ModuleNamespace)
-    , m_wasSeenInJIT(true)
-    , m_moduleNamespaceObject(accessCase.moduleNamespaceObject())
+    : m_moduleNamespaceObject(accessCase.moduleNamespaceObject())
     , m_moduleEnvironment(accessCase.moduleEnvironment())
     , m_scopeOffset(accessCase.scopeOffset())
+    , m_state(ModuleNamespace)
+    , m_wasSeenInJIT(true)
 {
 }

trunk/Source/JavaScriptCore/bytecode/GetByIdStatus.h

@@ -46 +46 @@
 class GetByIdStatus {
 public:
-    enum State {
+    enum State : uint8_t {
         // It's uncached so we have no information.
         NoInformation,
@@ -157 +157 @@
     bool appendVariant(const GetByIdVariant&);
     
-    State m_state;
+    
     Vector<GetByIdVariant, 1> m_variants;
-    bool m_wasSeenInJIT { false };
     JSModuleNamespaceObject* m_moduleNamespaceObject { nullptr };
     JSModuleEnvironment* m_moduleEnvironment { nullptr };
     ScopeOffset m_scopeOffset { };
+    State m_state;
+    bool m_wasSeenInJIT { false };
 };