Changeset 242679 in webkit

Timestamp:

Mar 9, 2019, 8:48:34 PM (7 years ago)

Author:

Alan Bujtas

Message:

[ContentChangeObserver] Click event fires immediately on hover menu at seriouseats.com
​https://bugs.webkit.org/show_bug.cgi?id=195520
<rdar://problem/48740098>

Reviewed by Simon Fraser.

Source/WebCore:

Unfortunately seriouseats has a 300ms hover intent delay to deal with accidental menupane pop-ups. This page also hides this
non-fixed width menupane using absolute positioning and negative left.

Test: fast/events/touch/ios/content-observation/move-content-from-offscreen.html

• page/ios/ContentChangeObserver.cpp:

(WebCore::ContentChangeObserver::didInstallDOMTimer):
(WebCore::ContentChangeObserver::StyleChangeScope::~StyleChangeScope):
(WebCore::ContentChangeObserver::StyleChangeScope::isConsideredHidden const): Content auhtors tend to use x - 1 values (where x = 10^y)

LayoutTests:

• fast/events/touch/ios/content-observation/move-content-from-offscreen-expected.txt: Added.
• fast/events/touch/ios/content-observation/move-content-from-offscreen.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/events/touch/ios/content-observation/move-content-from-offscreen-expected.txt (added)
• LayoutTests/fast/events/touch/ios/content-observation/move-content-from-offscreen.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/page/ios/ContentChangeObserver.cpp (modified) (3 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2019-03-09  Zalan Bujtas  <zalan@apple.com>
+
+        [ContentChangeObserver] Click event fires immediately on hover menu at seriouseats.com
+        https://bugs.webkit.org/show_bug.cgi?id=195520
+        <rdar://problem/48740098>
+
+        Reviewed by Simon Fraser.
+
+        * fast/events/touch/ios/content-observation/move-content-from-offscreen-expected.txt: Added.
+        * fast/events/touch/ios/content-observation/move-content-from-offscreen.html: Added.
+
 2019-03-09  Zalan Bujtas  <zalan@apple.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2019-03-09  Zalan Bujtas  <zalan@apple.com>
+
+        [ContentChangeObserver] Click event fires immediately on hover menu at seriouseats.com
+        https://bugs.webkit.org/show_bug.cgi?id=195520
+        <rdar://problem/48740098>
+
+        Reviewed by Simon Fraser.
+
+        Unfortunately seriouseats has a 300ms hover intent delay to deal with accidental menupane pop-ups. This page also hides this
+        non-fixed width menupane using absolute positioning and negative left.  
+
+        Test: fast/events/touch/ios/content-observation/move-content-from-offscreen.html
+
+        * page/ios/ContentChangeObserver.cpp:
+        (WebCore::ContentChangeObserver::didInstallDOMTimer):
+        (WebCore::ContentChangeObserver::StyleChangeScope::~StyleChangeScope):
+        (WebCore::ContentChangeObserver::StyleChangeScope::isConsideredHidden const): Content auhtors tend to use x - 1 values (where x = 10^y)
+
 2019-03-09  Chris Dumez  <cdumez@apple.com>
 

trunk/Source/WebCore/page/ios/ContentChangeObserver.cpp

@@ -67 +67 @@
     if (m_document.activeDOMObjectsAreSuspended())
         return;
-    if (timeout > 250_ms || !singleShot)
+    if (timeout > 300_ms || !singleShot)
         return;
     if (!isObservingDOMTimerScheduling())
@@ -318 +318 @@
         return m_wasHidden && !isConsideredHidden();
     };
-    
+
     if (changedFromHiddenToVisible() && isConsideredClickable())
         m_contentChangeObserver.contentVisibilityDidChange();
@@ -335 +335 @@
         return true;
 
-    auto width = style.width();
-    auto height = style.height();
+    auto width = style.logicalWidth();
+    auto height = style.logicalHeight();
     if ((width.isFixed() && !width.value()) || (height.isFixed() && !height.value()))
         return true;
 
-    auto top = style.top();
-    auto left = style.left();
+    auto top = style.logicalTop();
+    auto left = style.logicalLeft();
     // FIXME: This is trying to check if the element is outside of the viewport. This is incorrect for many reasons.
     if (left.isFixed() && width.isFixed() && -left.value() >= width.value())
         return true;
-
     if (top.isFixed() && height.isFixed() && -top.value() >= height.value())
+        return true;
+
+    // It's a common technique used to position content offscreen.
+    if (style.hasOutOfFlowPosition() && left.isFixed() && left.value() <= -999)
         return true;