Changeset 242716 in webkit

Timestamp:

Mar 11, 2019, 10:27:47 AM (7 years ago)

Author:

rmorisset@apple.com

Message:

IntlNumberFormat can be shrunk by 16 bytes
​https://bugs.webkit.org/show_bug.cgi?id=195505

Reviewed by Darin Adler.

• runtime/IntlNumberFormat.h:

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• runtime/IntlNumberFormat.h (modified) (3 diffs)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2019-03-11  Robin Morisset  <rmorisset@apple.com>
+
+        IntlNumberFormat can be shrunk by 16 bytes
+        https://bugs.webkit.org/show_bug.cgi?id=195505
+
+        Reviewed by Darin Adler.
+
+        * runtime/IntlNumberFormat.h:
+
 2019-03-11  Caio Lima  <ticaiolima@gmail.com>
 

trunk/Source/JavaScriptCore/runtime/IntlNumberFormat.h

@@ -65 +65 @@
 
 private:
-    enum class Style { Decimal, Percent, Currency };
-    enum class CurrencyDisplay { Code, Symbol, Name };
+    enum class Style : uint8_t { Decimal, Percent, Currency };
+    enum class CurrencyDisplay : uint8_t { Code, Symbol, Name };
 
     struct UNumberFormatDeleter {
@@ -77 +77 @@
     String m_locale;
     String m_numberingSystem;
-    Style m_style { Style::Decimal };
     String m_currency;
-    CurrencyDisplay m_currencyDisplay;
+    std::unique_ptr<UNumberFormat, UNumberFormatDeleter> m_numberFormat;
+    WriteBarrier<JSBoundFunction> m_boundFormat;
     unsigned m_minimumIntegerDigits { 1 };
     unsigned m_minimumFractionDigits { 0 };
@@ -85 +85 @@
     unsigned m_minimumSignificantDigits { 0 };
     unsigned m_maximumSignificantDigits { 0 };
-    std::unique_ptr<UNumberFormat, UNumberFormatDeleter> m_numberFormat;
-    WriteBarrier<JSBoundFunction> m_boundFormat;
+    Style m_style { Style::Decimal };
+    CurrencyDisplay m_currencyDisplay;
     bool m_useGrouping { true };
     bool m_initializedNumberFormat { false };