Changeset 242717 in webkit

Timestamp:

Mar 11, 2019, 10:39:35 AM (7 years ago)

Author:

rmorisset@apple.com

Message:

IntlCollator can be shrunk by 16 bytes
​https://bugs.webkit.org/show_bug.cgi?id=195503

Reviewed by Darin Adler.

• runtime/IntlCollator.h:

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• runtime/IntlCollator.h (modified) (2 diffs)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2019-03-11  Robin Morisset  <rmorisset@apple.com>
+
+        IntlCollator can be shrunk by 16 bytes
+        https://bugs.webkit.org/show_bug.cgi?id=195503
+
+        Reviewed by Darin Adler.
+
+        * runtime/IntlCollator.h:
+
 2019-03-11  Robin Morisset  <rmorisset@apple.com>
 

trunk/Source/JavaScriptCore/runtime/IntlCollator.h

@@ -60 +60 @@
 
 private:
-    enum class Usage { Sort, Search };
-    enum class Sensitivity { Base, Accent, Case, Variant };
-    enum class CaseFirst { Upper, Lower, False };
+    enum class Usage : uint8_t { Sort, Search };
+    enum class Sensitivity : uint8_t { Base, Accent, Case, Variant };
+    enum class CaseFirst : uint8_t { Upper, Lower, False };
 
     struct UCollatorDeleter {
@@ -73 +73 @@
     static ASCIILiteral caseFirstString(CaseFirst);
 
-    Usage m_usage;
     String m_locale;
     String m_collation;
+    WriteBarrier<JSBoundFunction> m_boundCompare;
+    std::unique_ptr<UCollator, UCollatorDeleter> m_collator;
+    Usage m_usage;
     Sensitivity m_sensitivity;
     CaseFirst m_caseFirst;
-    WriteBarrier<JSBoundFunction> m_boundCompare;
-    std::unique_ptr<UCollator, UCollatorDeleter> m_collator;
     bool m_numeric;
     bool m_ignorePunctuation;