Changeset 242718 in webkit

Timestamp:

Mar 11, 2019, 10:54:59 AM (7 years ago)

Author:

rmorisset@apple.com

Message:

IntlDateTimeFormat can be shrunk by 32 bytes
​https://bugs.webkit.org/show_bug.cgi?id=195504

Reviewed by Darin Adler.

• runtime/IntlDateTimeFormat.h:

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• runtime/IntlDateTimeFormat.h (modified) (3 diffs)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2019-03-11  Robin Morisset  <rmorisset@apple.com>
+
+        IntlDateTimeFormat can be shrunk by 32 bytes
+        https://bugs.webkit.org/show_bug.cgi?id=195504
+
+        Reviewed by Darin Adler.
+
+        * runtime/IntlDateTimeFormat.h:
+
 2019-03-11  Robin Morisset  <rmorisset@apple.com>
 

trunk/Source/JavaScriptCore/runtime/IntlDateTimeFormat.h

@@ -65 +65 @@
 
 private:
-    enum class Weekday { None, Narrow, Short, Long };
-    enum class Era { None, Narrow, Short, Long };
-    enum class Year { None, TwoDigit, Numeric };
-    enum class Month { None, TwoDigit, Numeric, Narrow, Short, Long };
-    enum class Day { None, TwoDigit, Numeric };
-    enum class Hour { None, TwoDigit, Numeric };
-    enum class Minute { None, TwoDigit, Numeric };
-    enum class Second { None, TwoDigit, Numeric };
-    enum class TimeZoneName { None, Short, Long };
+    enum class Weekday : uint8_t { None, Narrow, Short, Long };
+    enum class Era : uint8_t { None, Narrow, Short, Long };
+    enum class Year : uint8_t { None, TwoDigit, Numeric };
+    enum class Month : uint8_t { None, TwoDigit, Numeric, Narrow, Short, Long };
+    enum class Day : uint8_t { None, TwoDigit, Numeric };
+    enum class Hour : uint8_t { None, TwoDigit, Numeric };
+    enum class Minute : uint8_t { None, TwoDigit, Numeric };
+    enum class Second : uint8_t { None, TwoDigit, Numeric };
+    enum class TimeZoneName : uint8_t { None, Short, Long };
 
     struct UDateFormatDeleter {
@@ -90 +90 @@
     static ASCIILiteral timeZoneNameString(TimeZoneName);
 
-    bool m_initializedDateTimeFormat { false };
     WriteBarrier<JSBoundFunction> m_boundFormat;
     std::unique_ptr<UDateFormat, UDateFormatDeleter> m_dateFormat;
@@ -108 +107 @@
     Second m_second { Second::None };
     TimeZoneName m_timeZoneName { TimeZoneName::None };
+    bool m_initializedDateTimeFormat { false };
 
 #if JSC_ICU_HAS_UFIELDPOSITER