Changeset 242719 in webkit

Timestamp:

Mar 11, 2019, 11:22:02 AM (7 years ago)

Author:

aakash_jain@apple.com

Message:

[ews-app] Add support for submit-to-ews url
​https://bugs.webkit.org/show_bug.cgi?id=195477

Reviewed by Lucas Forschler.

• BuildSlaveSupport/ews-app/ews/fetcher.py:
• BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
• BuildSlaveSupport/ews-app/ews/templates/submittoews.html: Copied from QueueStatusServer/templates/submittoews.html.
• BuildSlaveSupport/ews-app/ews/urls.py:
• BuildSlaveSupport/ews-app/ews/views/submittoews.py: Added.

Location:

trunk/Tools

Files:

• BuildSlaveSupport/ews-app/ews/fetcher.py (modified) (1 diff)
• BuildSlaveSupport/ews-app/ews/templates/statusbubble.html (modified) (1 diff)
• BuildSlaveSupport/ews-app/ews/templates/submittoews.html (added)
• BuildSlaveSupport/ews-app/ews/urls.py (modified) (2 diffs)
• BuildSlaveSupport/ews-app/ews/views/submittoews.py (added)
• ChangeLog (modified) (1 diff)

trunk/Tools/BuildSlaveSupport/ews-app/ews/fetcher.py

@@ -49 +49 @@
 
 class BugzillaPatchFetcher():
-    def fetch(self):
-        patch_ids = Bugzilla.get_list_of_patches_needing_reviews()
+    def fetch(self, patch_ids=None):
+        if patch_ids and type(patch_ids) != list:
+            _log.error('Error: patch_ids should be a list, found: {}'.format(type(patch_ids)))
+            return -1
+
+        if not patch_ids:
+            patch_ids = Bugzilla.get_list_of_patches_needing_reviews()
         patch_ids = BugzillaPatchFetcher.filter_valid_patches(patch_ids)
         _log.debug('r? patches: {}'.format(patch_ids))

trunk/Tools/BuildSlaveSupport/ews-app/ews/templates/statusbubble.html

@@ -92 +92 @@
 
 {% if show_submit_to_ews %}
-  <form name="submit_to_ews" method="POST" action="/submit-to-ews">
+  <form name="submit_to_ews" method="POST" action="/submit-to-ews/">{% csrf_token %}
     <input type="hidden" name="patch_id" value="{{ patch_id }}">
     <input type="hidden" name="next_action" value="return_to_bubbles">

trunk/Tools/BuildSlaveSupport/ews-app/ews/urls.py

@@ -27 +27 @@
 from ews.views.results import Results
 from ews.views.statusbubble import StatusBubble
+from ews.views.submittoews import SubmitToEWS
 
 app_name = 'ews'
@@ -38 +39 @@
     # ex: /status-bubble/5
     url(r'^status-bubble/(?P<patch_id>[0-9]+)/$', StatusBubble.as_view(), name='statusbubble'),
+    # ex: /submit-to-ews/
+    url(r'^submit-to-ews/$', SubmitToEWS.as_view(), name='submittoews'),
 ]

trunk/Tools/ChangeLog

@@ +1 @@
+2019-03-11  Aakash Jain  <aakash_jain@apple.com>
+
+        [ews-app] Add support for submit-to-ews url
+        https://bugs.webkit.org/show_bug.cgi?id=195477
+
+        Reviewed by Lucas Forschler.
+
+        * BuildSlaveSupport/ews-app/ews/fetcher.py:
+        * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
+        * BuildSlaveSupport/ews-app/ews/templates/submittoews.html: Copied from QueueStatusServer/templates/submittoews.html.
+        * BuildSlaveSupport/ews-app/ews/urls.py:
+        * BuildSlaveSupport/ews-app/ews/views/submittoews.py: Added.
+
 2019-03-11  Ryan Haddad  <ryanhaddad@apple.com>