Changeset 242731 in webkit

Timestamp:

Mar 11, 2019, 1:05:07 PM (7 years ago)

Author:

Nikita Vasilyev

Message:

REGRESSION(r242622): Web Inspector: Fix asserts "Overridden property is missing overridingProperty"
​https://bugs.webkit.org/show_bug.cgi?id=195515
<rdar://problem/48737315>

Reviewed by Matt Baker.

• UserInterface/Views/SpreadsheetStyleProperty.js:

(WI.SpreadsheetStyleProperty.prototype.updateStatus):

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Views/SpreadsheetStyleProperty.js (modified) (1 diff)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2019-03-11  Nikita Vasilyev  <nvasilyev@apple.com>
+
+        REGRESSION(r242622): Web Inspector: Fix asserts "Overridden property is missing overridingProperty"
+        https://bugs.webkit.org/show_bug.cgi?id=195515
+        <rdar://problem/48737315>
+
+        Reviewed by Matt Baker.
+
+        * UserInterface/Views/SpreadsheetStyleProperty.js:
+        (WI.SpreadsheetStyleProperty.prototype.updateStatus):
+
 2019-03-07  Nikita Vasilyev  <nvasilyev@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/Views/SpreadsheetStyleProperty.js

@@ -263 +263 @@
 
         if (this._property.overridden) {
-            if (!this._jumpToEffectivePropertyButton && this._delegate && this._delegate.spreadsheetStylePropertySelectByProperty) {
+            if (!this._jumpToEffectivePropertyButton && this._delegate && this._delegate.spreadsheetStylePropertySelectByProperty && WI.settings.experimentalEnableStylesJumpToEffective.value) {
                 console.assert(this._property.overridingProperty, `Overridden property is missing overridingProperty: ${this._property.formattedText}`);
                 if (this._property.overridingProperty) {