Changeset 242733 in webkit

Timestamp:

Mar 11, 2019, 1:17:50 PM (7 years ago)

Author:

Chris Dumez

Message:

Regression(r242664) WebKit.WebsitePoliciesDeviceOrientationEventEnabled API test is timing out
​https://bugs.webkit.org/show_bug.cgi?id=195561

Reviewed by Youenn Fablet.

Make sure the JS in the test requests for permission to receive device orientation events.

• TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2019-03-11  Chris Dumez  <cdumez@apple.com>
+
+        Regression(r242664) WebKit.WebsitePoliciesDeviceOrientationEventEnabled API test is timing out
+        https://bugs.webkit.org/show_bug.cgi?id=195561
+
+        Reviewed by Youenn Fablet.
+
+        Make sure the JS in the test requests for permission to receive device orientation events.
+
+        * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
+
 2019-03-11  Youenn Fablet  <youenn@apple.com>
 

trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm

@@ -1294 +1294 @@
     finishedNavigation = false;
 
+    bool askedForPermission = false;
+    [webView evaluateJavaScript:@"DeviceOrientationEvent.requestPermission()" completionHandler: [&] (id result, NSError *error) {
+        askedForPermission = true;
+    }];
+    TestWebKitAPI::Util::run(&askedForPermission);
+
     __block bool didReceiveMessage = false;
     [webView performAfterReceivingMessage:@"received-device-orientation-event" action:^{