Changeset 242779 in webkit

Timestamp:

Mar 11, 2019, 11:07:14 PM (7 years ago)

Author:

rniwa@webkit.org

Message:

Remove OpenCube QuickMenu quirks from navigator.appVersion
​https://bugs.webkit.org/show_bug.cgi?id=195600

Reviewed by Simon Fraser.

Remove the site specific quirk added in r35050 for OpenCube QuickMenu library for nwa.com

Blink removed this code back in 2013. The fact Chrome has been shipping successfully without
this quirk for six years is a good evidence that it's no longer needed for the Web compatibility.

• page/Navigator.cpp:

(WebCore::Navigator::appVersion const):
(WebCore::shouldHideFourDot): Deleted.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• page/Navigator.cpp (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2019-03-11  Ryosuke Niwa  <rniwa@webkit.org>
+
+        Remove OpenCube QuickMenu quirks from navigator.appVersion
+        https://bugs.webkit.org/show_bug.cgi?id=195600
+
+        Reviewed by Simon Fraser.
+
+        Remove the site specific quirk added in r35050 for OpenCube QuickMenu library for nwa.com
+
+        Blink removed this code back in 2013. The fact Chrome has been shipping successfully without
+        this quirk for six years is a good evidence that it's no longer needed for the Web compatibility.
+
+        * page/Navigator.cpp:
+        (WebCore::Navigator::appVersion const):
+        (WebCore::shouldHideFourDot): Deleted.
+
 2019-03-11  Ryan Haddad  <ryanhaddad@apple.com>
 

trunk/Source/WebCore/page/Navigator.cpp

@@ -57 +57 @@
 Navigator::~Navigator() = default;
 
-// If this function returns true, we need to hide the substring "4." that would otherwise
-// appear in the appVersion string. This is to avoid problems with old versions of a
-// library called OpenCube QuickMenu, which as of this writing is still being used on
-// sites such as nwa.com -- the library thinks Safari is Netscape 4 if we don't do this!
-static bool shouldHideFourDot(Frame& frame)
-{
-    auto* sourceURL = frame.script().sourceURL();
-    if (!sourceURL)
-        return false;
-    if (!(sourceURL->endsWith("/dqm_script.js") || sourceURL->endsWith("/dqm_loader.js") || sourceURL->endsWith("/tdqm_loader.js")))
-        return false;
-    return frame.settings().needsSiteSpecificQuirks();
-}
-
 String Navigator::appVersion() const
 {
@@ -78 +64 @@
     if (RuntimeEnabledFeatures::sharedFeatures().webAPIStatisticsEnabled())
         ResourceLoadObserver::shared().logNavigatorAPIAccessed(*frame->document(), ResourceLoadStatistics::NavigatorAPI::AppVersion);
-    String appVersion = NavigatorBase::appVersion();
-    if (shouldHideFourDot(*frame))
-        appVersion.replace("4.", "4_");
-    return appVersion;
+    return NavigatorBase::appVersion();
 }