Changeset 242785 in webkit

Timestamp:

Mar 12, 2019, 12:10:58 AM (7 years ago)

Author:

commit-queue@webkit.org

Message:

Web Inspector: Timelines - Improve handling of past recordings (readonly)
​https://bugs.webkit.org/show_bug.cgi?id=195594

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2019-03-12
Reviewed by Devin Rousso.

• UserInterface/Views/TimelineRecordingContentView.js:

(WI.TimelineRecordingContentView.prototype._clearTimeline):
Don't allow clearing of a readonly recording.

• UserInterface/Views/TimelineTabContentView.js:

(WI.TimelineTabContentView.prototype._toggleRecordingOnSpacebar):
Don't do anything when viewing a readonly recording.

(WI.TimelineTabContentView.prototype._recordButtonClicked):
Start a new recording if viewing a readonly recording.

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Views/TimelineRecordingContentView.js (modified) (1 diff)
• UserInterface/Views/TimelineTabContentView.js (modified) (2 diffs)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2019-03-12  Joseph Pecoraro  <pecoraro@apple.com>
+
+        Web Inspector: Timelines - Improve handling of past recordings (readonly)
+        https://bugs.webkit.org/show_bug.cgi?id=195594
+
+        Reviewed by Devin Rousso.
+
+        * UserInterface/Views/TimelineRecordingContentView.js:
+        (WI.TimelineRecordingContentView.prototype._clearTimeline):
+        Don't allow clearing of a readonly recording.
+
+        * UserInterface/Views/TimelineTabContentView.js:
+        (WI.TimelineTabContentView.prototype._toggleRecordingOnSpacebar):
+        Don't do anything when viewing a readonly recording.
+
+        (WI.TimelineTabContentView.prototype._recordButtonClicked):
+        Start a new recording if viewing a readonly recording.
+
 2019-03-11  Joseph Pecoraro  <pecoraro@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/Views/TimelineRecordingContentView.js

@@ -565 +565 @@
     _clearTimeline(event)
     {
+        if (this._recording.readonly)
+            return;
+
         if (WI.timelineManager.activeRecording === this._recording && WI.timelineManager.isCapturing())
             WI.timelineManager.stopCapturing();

trunk/Source/WebInspectorUI/UserInterface/Views/TimelineTabContentView.js

@@ -446 +446 @@
     _toggleRecordingOnSpacebar(event)
     {
+        if (WI.timelineManager.activeRecording.readonly)
+            return;
+
         if (WI.isEventTargetAnEditableField(event))
             return;
@@ -481 +484 @@
     {
         let shouldCreateNewRecording = window.event ? window.event.shiftKey : false;
+        if (WI.timelineManager.activeRecording.readonly)
+            shouldCreateNewRecording = true;
+
         this._recordButton.toggled = !WI.timelineManager.isCapturing();
         this._toggleRecording(shouldCreateNewRecording);