Changeset 242847 in webkit

Timestamp:

Mar 13, 2019, 12:48:12 AM (7 years ago)

Author:

Fujii Hironori

Message:

[Win][PlayStation] Remove WebCore::standardUserAgentForURL
​https://bugs.webkit.org/show_bug.cgi?id=195662

Reviewed by Ryosuke Niwa.

Source/WebCore:

WebCore::standardUserAgentForURL is just a stub in Windows port.

No new tests because there is no behavior change.

• platform/win/UserAgentWin.cpp:

(WebCore::standardUserAgentForURL): Deleted.

• platform/playstation/UserAgentPlayStation.cpp:

(WebCore::standardUserAgentForURL): Deleted.

Source/WebKit:

• WebProcess/WebPage/win/WebPageWin.cpp:

(WebKit::WebPage::platformUserAgent const): Return an empty string as well as mac/ios ports.

Location:

trunk/Source

Files:

• WebCore/ChangeLog (modified) (1 diff)
• WebCore/platform/playstation/UserAgentPlayStation.cpp (modified) (1 diff)
• WebCore/platform/win/UserAgentWin.cpp (modified) (1 diff)
• WebKit/ChangeLog (modified) (1 diff)
• WebKit/WebProcess/WebPage/win/WebPageWin.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2019-03-13  Fujii Hironori  <Hironori.Fujii@sony.com>
+
+        [Win][PlayStation] Remove WebCore::standardUserAgentForURL
+        https://bugs.webkit.org/show_bug.cgi?id=195662
+
+        Reviewed by Ryosuke Niwa.
+
+        WebCore::standardUserAgentForURL is just a stub in Windows port.
+
+        No new tests because there is no behavior change.
+
+        * platform/win/UserAgentWin.cpp:
+        (WebCore::standardUserAgentForURL): Deleted.
+        * platform/playstation/UserAgentPlayStation.cpp:
+        (WebCore::standardUserAgentForURL): Deleted.
+
 2019-03-12  Ross Kirsling  <ross.kirsling@sony.com>
 

trunk/Source/WebCore/platform/playstation/UserAgentPlayStation.cpp

@@ -34 +34 @@
 }
 
-String standardUserAgentForURL(const URL&)
-{
-    // The null string means we don't need a specific UA for the given URL.
-    return emptyString();
-}
-
 } // namespace WebCore

trunk/Source/WebCore/platform/win/UserAgentWin.cpp

@@ -50 +50 @@
 }
 
-String standardUserAgentForURL(const URL& url)
-{
-    // The null string means we don't need a specific UA for the given URL.
-    return { };
-}
-
 } // namespace WebCore

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2019-03-13  Fujii Hironori  <Hironori.Fujii@sony.com>
+
+        [Win][PlayStation] Remove WebCore::standardUserAgentForURL
+        https://bugs.webkit.org/show_bug.cgi?id=195662
+
+        Reviewed by Ryosuke Niwa.
+
+        * WebProcess/WebPage/win/WebPageWin.cpp:
+        (WebKit::WebPage::platformUserAgent const): Return an empty string as well as mac/ios ports.
+
 2019-03-12  Ross Kirsling  <ross.kirsling@sony.com>
 

trunk/Source/WebKit/WebProcess/WebPage/win/WebPageWin.cpp

@@ -114 +114 @@
 }
 
-String WebPage::platformUserAgent(const URL& url) const
-{
-    if (url.isNull() || !m_page->settings().needsSiteSpecificQuirks())
-        return String();
-
-    return WebCore::standardUserAgentForURL(url);
+String WebPage::platformUserAgent(const URL&) const
+{
+    return { };
 }