Changeset 242853 in webkit

Timestamp:

Mar 13, 2019, 1:24:26 AM (7 years ago)

Author:

bshafiei@apple.com

Message:

Cherry-pick r241632. rdar://problem/48839379

Sample domainsVisited diagnostic logging
​https://bugs.webkit.org/show_bug.cgi?id=194657

Reviewed by Ryosuke Niwa.

Sample domainsVisited diagnostic logging, we are getting a lot of data from
this key and this is hurting our other keys.

• page/Page.cpp: (WebCore::Page::logNavigation):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@241632 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Location:

branches/safari-607-branch/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• page/Page.cpp (modified) (1 diff)

branches/safari-607-branch/Source/WebCore/ChangeLog

@@ +1 @@
+2019-03-13  Babak Shafiei  <bshafiei@apple.com>
+
+        Cherry-pick r241632. rdar://problem/48839379
+
+    Sample domainsVisited diagnostic logging
+    https://bugs.webkit.org/show_bug.cgi?id=194657
+    
+    Reviewed by Ryosuke Niwa.
+    
+    Sample domainsVisited diagnostic logging, we are getting a lot of data from
+    this key and this is hurting our other keys.
+    
+    * page/Page.cpp:
+    (WebCore::Page::logNavigation):
+    
+    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@241632 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+    2019-02-15  Chris Dumez  <cdumez@apple.com>
+
+            Sample domainsVisited diagnostic logging
+            https://bugs.webkit.org/show_bug.cgi?id=194657
+
+            Reviewed by Ryosuke Niwa.
+
+            Sample domainsVisited diagnostic logging, we are getting a lot of data from
+            this key and this is hurting our other keys.
+
+            * page/Page.cpp:
+            (WebCore::Page::logNavigation):
+
 2019-03-13  Babak Shafiei  <bshafiei@apple.com>
 

branches/safari-607-branch/Source/WebCore/page/Page.cpp

@@ -2363 +2363 @@
 
     if (!navigation.domain.isEmpty())
-        diagnosticLoggingClient().logDiagnosticMessageWithEnhancedPrivacy(DiagnosticLoggingKeys::domainVisitedKey(), navigation.domain, ShouldSample::No);
+        diagnosticLoggingClient().logDiagnosticMessageWithEnhancedPrivacy(DiagnosticLoggingKeys::domainVisitedKey(), navigation.domain, ShouldSample::Yes);
 }