Changeset 242882 in webkit

Timestamp:

Mar 13, 2019, 8:33:01 AM (7 years ago)

Author:

commit-queue@webkit.org

Message:

[Flatpak] Expand submodule recursively
​https://bugs.webkit.org/show_bug.cgi?id=195672

Building WPE with flatpak was impossible without that as it was raising an exception.
Also update wpebackend-fdo to match what is built in jhbuild

Patch by Thibault Saunier <​tsaunier@igalia.com> on 2019-03-13
Reviewed by Philippe Normand.

• flatpak/flatpakutils.py:

(expand_submodules_recurse):
(expand_manifest):

• flatpak/org.webkit.WPEModules.yaml:

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• flatpak/flatpakutils.py (modified) (2 diffs)
• flatpak/org.webkit.WPEModules.yaml (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2019-03-13  Thibault Saunier  <tsaunier@igalia.com>
+
+        [Flatpak] Expand submodule recursively
+        https://bugs.webkit.org/show_bug.cgi?id=195672
+
+        Building WPE with flatpak was impossible without that as it was raising an exception.
+        Also update wpebackend-fdo to match what is built in jhbuild
+
+        Reviewed by Philippe Normand.
+
+        * flatpak/flatpakutils.py:
+        (expand_submodules_recurse):
+        (expand_manifest):
+        * flatpak/org.webkit.WPEModules.yaml:
+
 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
 

trunk/Tools/flatpak/flatpakutils.py

@@ -165 +165 @@
 
 
+def expand_submodules_recurse(modules, manifest_path, port_name, command):
+    all_modules = []
+    if type(modules) is str:
+        submanifest_path = os.path.join(os.path.dirname(manifest_path), modules)
+        submanifest = load_manifest(submanifest_path, port_name=port_name, command=command)
+        all_modules.extend(expand_submodules_recurse(submanifest, submanifest_path, port_name, command))
+        return all_modules
+
+    for module in modules:
+        if type(module) is str:
+            submanifest_path = os.path.join(os.path.dirname(manifest_path), module)
+            submanifest = load_manifest(submanifest_path, port_name=port_name, command=command)
+            all_modules.extend(expand_submodules_recurse(submanifest, submanifest_path, port_name, command))
+        else:
+            all_modules.append(module)
+
+    return all_modules
+
 def expand_manifest(manifest_path, outfile, port_name, source_root, command):
     """Creates the manifest file."""
@@ -189 +207 @@
             overriden_modules = []
     for modules in manifest["modules"]:
-        submanifest_path = None
-        if type(modules) is str:
-            submanifest_path = os.path.join(os.path.dirname(manifest_path), modules)
-            modules = load_manifest(submanifest_path, port_name=port_name, command=command)
+        modules = expand_submodules_recurse(modules, manifest_path, port_name, command)
 
         if not isinstance(modules, list):

trunk/Tools/flatpak/org.webkit.WPEModules.yaml

@@ -8 +8 @@
   buildsystem: cmake-ninja
   sources:
-    - type: archive
-      url: https://wpewebkit.org/releases/wpebackend-fdo-1.1.0.tar.xz
-      sha256: f6c72130d16e50860cb83eb0f6e109c76f1826d2c6bee39025fb3651941761e7
+    - type: git
+      url: https://github.com/Igalia/wpebackend-fdo.git
+      commit: fa227dac7c6a133d62b35d7a6af0332582b64d4d