Changeset 242892 in webkit

Timestamp:

Mar 13, 2019, 11:09:00 AM (7 years ago)

Author:

commit-queue@webkit.org

Message:

Fix testbmalloc build
​https://bugs.webkit.org/show_bug.cgi?id=195660

Patch by Sam Weinig <​sam@webkit.org> on 2019-03-13
Reviewed by Geoffrey Garen.

• bmalloc.xcodeproj/project.pbxproj:

Link Foundation in when building testbmalloc. Since bmalloc requires Foundation, and is a static
library, all clients of bmalloc are required to link it themselves.

• bmalloc/IsoPageInlines.h:
• bmalloc/StdLibExtras.h: Added.

(bmalloc::bitwise_cast):
Add bitwise_cast implementation, and use it in IsoPageInlines.h. It is a layering violation
to expect the one from WTF to be available, as seems to have been the case.

Location:

trunk/Source/bmalloc

Files:

• ChangeLog (modified) (1 diff)
• bmalloc.xcodeproj/project.pbxproj (modified) (5 diffs)
• bmalloc/IsoPageInlines.h (modified) (1 diff)
• bmalloc/StdLibExtras.h (added)

trunk/Source/bmalloc/ChangeLog

@@ +1 @@
+2019-03-13  Sam Weinig  <sam@webkit.org>
+
+        Fix testbmalloc build
+        https://bugs.webkit.org/show_bug.cgi?id=195660
+
+        Reviewed by Geoffrey Garen.
+
+        * bmalloc.xcodeproj/project.pbxproj:
+        Link Foundation in when building testbmalloc. Since bmalloc requires Foundation, and is a static
+        library, all clients of bmalloc are required to link it themselves.
+        
+        * bmalloc/IsoPageInlines.h:
+        * bmalloc/StdLibExtras.h: Added.
+        (bmalloc::bitwise_cast):
+        Add bitwise_cast implementation, and use it in IsoPageInlines.h. It is a layering violation
+        to expect the one from WTF to be available, as seems to have been the case.
+
 2019-03-12  Robin Morisset  <rmorisset@apple.com>
 

trunk/Source/bmalloc/bmalloc.xcodeproj/project.pbxproj

@@ -138 +138 @@
                 7939885B2076EEB60074A2E7 /* BulkDecommit.h in Headers */ = {isa = PBXBuildFile; fileRef = 7939885A2076EEB50074A2E7 /* BulkDecommit.h */; settings = {ATTRIBUTES = (Private, ); }; };
                 795AB3C7206E0D340074FE76 /* PhysicalPageMap.h in Headers */ = {isa = PBXBuildFile; fileRef = 795AB3C6206E0D250074FE76 /* PhysicalPageMap.h */; settings = {ATTRIBUTES = (Private, ); }; };
+                7C571EFF22388B080077A3C7 /* Foundation.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = 142FC6212096409E00A99362 /* Foundation.framework */; };
+                7C571F0122388B840077A3C7 /* StdLibExtras.h in Headers */ = {isa = PBXBuildFile; fileRef = 7C571F0022388B840077A3C7 /* StdLibExtras.h */; settings = {ATTRIBUTES = (Private, ); }; };
                 AD0934331FCF406D00E85EB5 /* BCompiler.h in Headers */ = {isa = PBXBuildFile; fileRef = AD0934321FCF405000E85EB5 /* BCompiler.h */; settings = {ATTRIBUTES = (Private, ); }; };
                 AD14AD29202529C400890E3B /* ProcessCheck.h in Headers */ = {isa = PBXBuildFile; fileRef = AD14AD27202529A600890E3B /* ProcessCheck.h */; };
@@ -302 +304 @@
                 7939885A2076EEB50074A2E7 /* BulkDecommit.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = BulkDecommit.h; path = bmalloc/BulkDecommit.h; sourceTree = "<group>"; };
                 795AB3C6206E0D250074FE76 /* PhysicalPageMap.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; name = PhysicalPageMap.h; path = bmalloc/PhysicalPageMap.h; sourceTree = "<group>"; };
+                7C571F0022388B840077A3C7 /* StdLibExtras.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; name = StdLibExtras.h; path = bmalloc/StdLibExtras.h; sourceTree = "<group>"; };
                 A1B89B86221DFFEE00EB4CEA /* SDKVariant.xcconfig */ = {isa = PBXFileReference; lastKnownFileType = text.xcconfig; path = SDKVariant.xcconfig; sourceTree = "<group>"; };
                 AD0934321FCF405000E85EB5 /* BCompiler.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = BCompiler.h; path = bmalloc/BCompiler.h; sourceTree = "<group>"; };
@@ -314 +317 @@
                         buildActionMask = 2147483647;
                         files = (
+                                7C571EFF22388B080077A3C7 /* Foundation.framework in Frameworks */,
                                 0F7EB7FA1F95414C00F1ABCB /* libbmalloc.a in Frameworks */,
                         );
@@ -549 +553 @@
                                 145F6878179E3A4400D65598 /* Range.h */,
                                 148EFAE61D6B953B008E721E /* ScopeExit.h */,
+                                7C571F0022388B840077A3C7 /* StdLibExtras.h */,
                                 1417F64F18B7280C0076FA3F /* Syscall.h */,
                                 1479E21217A1A255006D4E9D /* Vector.h */,
@@ -661 +666 @@
                                 14DD78BC18F48D6B00950702 /* SmallLine.h in Headers */,
                                 14DD78BD18F48D6B00950702 /* SmallPage.h in Headers */,
+                                7C571F0122388B840077A3C7 /* StdLibExtras.h in Headers */,
                                 14DD78CE18F48D7500950702 /* Syscall.h in Headers */,
                                 14DD78CF18F48D7500950702 /* Vector.h in Headers */,

trunk/Source/bmalloc/bmalloc/IsoPageInlines.h

@@ -29 +29 @@
 #include "IsoDirectory.h"
 #include "IsoPage.h"
+#include "StdLibExtras.h"
 #include "VMAllocate.h"