Changeset 242936 in webkit

Timestamp:

Mar 13, 2019, 10:44:24 PM (7 years ago)

Author:

benjamin@webkit.org

Message:

Fix the argument type of RenderView::resumePausedImageAnimationsIfNeeded()
​https://bugs.webkit.org/show_bug.cgi?id=195659

Reviewed by Saam Barati.

The two callers of resumePausedImageAnimationsIfNeeded() both get the IntRect
as a reference. The rect was going on the stack then used as a reference again.

• rendering/RenderView.cpp:

(WebCore::RenderView::resumePausedImageAnimationsIfNeeded):

• rendering/RenderView.h:

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• rendering/RenderView.cpp (modified) (1 diff)
• rendering/RenderView.h (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2019-03-13  Benjamin Poulain  <benjamin@webkit.org>
+
+        Fix the argument type of RenderView::resumePausedImageAnimationsIfNeeded()
+        https://bugs.webkit.org/show_bug.cgi?id=195659
+
+        Reviewed by Saam Barati.
+
+        The two callers of resumePausedImageAnimationsIfNeeded() both get the IntRect
+        as a reference. The rect was going on the stack then used as a reference again.
+
+        * rendering/RenderView.cpp:
+        (WebCore::RenderView::resumePausedImageAnimationsIfNeeded):
+        * rendering/RenderView.h:
+
 2019-03-13  Zalan Bujtas  <zalan@apple.com>
 

trunk/Source/WebCore/rendering/RenderView.cpp

@@ -865 +865 @@
 }
 
-void RenderView::resumePausedImageAnimationsIfNeeded(IntRect visibleRect)
+void RenderView::resumePausedImageAnimationsIfNeeded(const IntRect& visibleRect)
 {
     Vector<std::pair<RenderElement*, CachedImage*>, 10> toRemove;

trunk/Source/WebCore/rendering/RenderView.h

@@ -167 +167 @@
     void registerForVisibleInViewportCallback(RenderElement&);
     void unregisterForVisibleInViewportCallback(RenderElement&);
-    void resumePausedImageAnimationsIfNeeded(IntRect visibleRect);
+    void resumePausedImageAnimationsIfNeeded(const IntRect& visibleRect);
     void addRendererWithPausedImageAnimations(RenderElement&, CachedImage&);
     void removeRendererWithPausedImageAnimations(RenderElement&);