Changeset 242966 in webkit

Timestamp:

Mar 14, 2019, 2:44:35 PM (7 years ago)

Author:

aakash_jain@apple.com

Message:

[ews-app] Gracefully handle the case when state_string is None
​https://bugs.webkit.org/show_bug.cgi?id=195753

Reviewed by Lucas Forschler.

• BuildSlaveSupport/ews-app/ews/models/build.py:
• BuildSlaveSupport/ews-app/ews/models/step.py:

Location:

trunk/Tools

Files:

• BuildSlaveSupport/ews-app/ews/models/build.py (modified) (1 diff)
• BuildSlaveSupport/ews-app/ews/models/step.py (modified) (1 diff)
• ChangeLog (modified) (1 diff)

trunk/Tools/BuildSlaveSupport/ews-app/ews/models/build.py

@@ -56 +56 @@
             return ERR_UNEXPECTED
 
+        if state_string is None:
+            state_string = ''
+
         uid = BuildbotInstance.get_uid(hostname, build_id)
         build = Build.get_existing_build(uid)

trunk/Tools/BuildSlaveSupport/ews-app/ews/models/step.py

@@ -52 +52 @@
             return ERR_UNEXPECTED
 
+        if state_string is None:
+            state_string = ''
+
         step_uid = BuildbotInstance.get_uid(hostname, step_id)
         build_uid = BuildbotInstance.get_uid(hostname, build_id)

trunk/Tools/ChangeLog

@@ +1 @@
+2019-03-14  Aakash Jain  <aakash_jain@apple.com>
+
+        [ews-app] Gracefully handle the case when state_string is None
+        https://bugs.webkit.org/show_bug.cgi?id=195753
+
+        Reviewed by Lucas Forschler.
+
+        * BuildSlaveSupport/ews-app/ews/models/build.py:
+        * BuildSlaveSupport/ews-app/ews/models/step.py:
+
 2019-03-14  Aakash Jain  <aakash_jain@apple.com>