⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Changeset 242969 in webkit


Ignore:
Timestamp:
Mar 14, 2019, 3:08:53 PM (7 years ago)
Author:
aakash_jain@apple.com
Message:

[ews-build] Make descriptionDone messages more readable
​https://bugs.webkit.org/show_bug.cgi?id=195760

Reviewed by Lucas Forschler.

  • BuildSlaveSupport/ews-build/steps.py:
  • BuildSlaveSupport/ews-build/steps_unittest.py:
Location:
trunk/Tools
Files:
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/Tools/BuildSlaveSupport/ews-build/steps.py

    r242817 r242969  
    4141    name = "configure-build"
    4242    description = ["configuring build"]
    43     descriptionDone = ["configured build"]
     43    descriptionDone = ["Configured build"]
    4444
    4545    def __init__(self, platform, configuration, architectures, buildOnly, additionalArguments):
    … …  
    100100    name = 'clean-working-directory'
    101101    description = ['clean-working-directory running']
    102     descriptionDone = ['clean-working-directory']
     102    descriptionDone = ['Cleaned working directory']
    103103    flunkOnFailure = True
    104104    haltOnFailure = True
    … …  
    109109    name = 'apply-patch'
    110110    description = ['applying-patch']
    111     descriptionDone = ['apply-patch']
     111    descriptionDone = ['Applied patch']
    112112    flunkOnFailure = True
    113113    haltOnFailure = True
    … …  
    134134    name = 'check-patch-relevance'
    135135    description = ['check-patch-relevance running']
    136     descriptionDone = ['check-patch-relevance']
     136    descriptionDone = ['Checked patch relevance']
    137137    flunkOnFailure = True
    138138    haltOnFailure = True
    … …  
    225225    name = 'validate-patch'
    226226    description = ['validate-patch running']
    227     descriptionDone = ['validate-patch']
     227    descriptionDone = ['Validated patch']
    228228    flunkOnFailure = True
    229229    haltOnFailure = True
    … …  
    363363class UnApplyPatchIfRequired(CleanWorkingDirectory):
    364364    name = 'unapply-patch'
     365    descriptionDone = ['Unapplied patch']
    365366
    366367    def doStepIf(self, step):
    … …  
    474475    name = "compile-webkit"
    475476    description = ["compiling"]
    476     descriptionDone = ["compiled"]
     477    descriptionDone = ["Compiled WebKit"]
    477478    env = {'MFLAGS': ''}
    478479    warningPattern = ".*arning: .*"
    … …  
    523524class CompileJSCOnly(CompileWebKit):
    524525    name = "build-jsc"
     526    descriptionDone = ["Compiled JSC"]
    525527    command = ["perl", "Tools/Scripts/build-jsc", WithProperties("--%(configuration)s")]
    526528
    … …  
    585587    name = "delete-WebKitBuild-directory"
    586588    description = ["deleting WebKitBuild directory"]
    587     descriptionDone = ["deleted WebKitBuild directory"]
     589    descriptionDone = ["Deleted WebKitBuild directory"]
    588590    command = ["python", "Tools/BuildSlaveSupport/clean-build", WithProperties("--platform=%(fullPlatform)s"), WithProperties("--%(configuration)s")]
    589591
    … …  
    592594    name = "kill-old-processes"
    593595    description = ["killing old processes"]
    594     descriptionDone = ["killed old processes"]
     596    descriptionDone = ["Killed old processes"]
    595597    command = ["python", "Tools/BuildSlaveSupport/kill-old-processes", "buildbot"]
    596598
    … …  
    637639    name = 'archive-built-product'
    638640    description = ['archiving built product']
    639     descriptionDone = ['archived built product']
     641    descriptionDone = ['Archived built product']
    640642    haltOnFailure = True
    641643
    … …  
    661663    name = 'download-built-product'
    662664    description = ['downloading built product']
    663     descriptionDone = ['downloaded built product']
     665    descriptionDone = ['Downloaded built product']
    664666    haltOnFailure = True
    665667    flunkOnFailure = True
    … …  
    671673    name = 'extract-built-product'
    672674    description = ['extracting built product']
    673     descriptionDone = ['extracted built product']
     675    descriptionDone = ['Extracted built product']
    674676    haltOnFailure = True
    675677    flunkOnFailure = True
    … …  
    704706    name = 'archive-test-results'
    705707    description = ['archiving test results']
    706     descriptionDone = ['archived test results']
     708    descriptionDone = ['Archived test results']
    707709    haltOnFailure = True
    708710
    … …  
    710712class UploadTestResults(transfer.FileUpload):
    711713    name = 'upload-test-results'
     714    descriptionDone = ['Uploaded test results']
    712715    workersrc = 'layout-test-results.zip'
    713716    masterdest = Interpolate('public_html/results/%(prop:buildername)s/r%(prop:patch_id)s-%(prop:buildnumber)s.zip')
    … …  
    727730    resultDirectory = Interpolate('public_html/results/%(prop:buildername)s/r%(prop:patch_id)s-%(prop:buildnumber)s')
    728731
    729     descriptionDone = ['uploaded results']
     732    descriptionDone = ['Extracted test results']
    730733    command = ['unzip', zipFile, '-d', resultDirectory]
    731734    renderables = ['resultDirectory']

  • trunk/Tools/BuildSlaveSupport/ews-build/steps_unittest.py

    r239783 r242969  
    398398            + 0,
    399399        )
    400         self.expectOutcome(result=SUCCESS, state_string='killed old processes')
     400        self.expectOutcome(result=SUCCESS, state_string='Killed old processes')
    401401        return self.runStep()
    402402
    … …  
    411411            + 2,
    412412        )
    413         self.expectOutcome(result=FAILURE, state_string='killed old processes (failure)')
     413        self.expectOutcome(result=FAILURE, state_string='Killed old processes (failure)')
    414414        return self.runStep()
    415415
    … …  
    433433            + 0,
    434434        )
    435         self.expectOutcome(result=SUCCESS, state_string='deleted WebKitBuild directory')
     435        self.expectOutcome(result=SUCCESS, state_string='Deleted WebKitBuild directory')
    436436        return self.runStep()
    437437
    … …  
    447447            + 2,
    448448        )
    449         self.expectOutcome(result=FAILURE, state_string='deleted WebKitBuild directory (failure)')
     449        self.expectOutcome(result=FAILURE, state_string='Deleted WebKitBuild directory (failure)')
    450450        return self.runStep()
    451451
    … …  
    469469            + 0,
    470470        )
    471         self.expectOutcome(result=SUCCESS, state_string='compiled')
     471        self.expectOutcome(result=SUCCESS, state_string='Compiled WebKit')
    472472        return self.runStep()
    473473
    … …  
    483483            + 2,
    484484        )
    485         self.expectOutcome(result=FAILURE, state_string='compiled (failure)')
     485        self.expectOutcome(result=FAILURE, state_string='Compiled WebKit (failure)')
    486486        return self.runStep()
    487487
    … …  
    506506            + 0,
    507507        )
    508         self.expectOutcome(result=SUCCESS, state_string='compiled')
     508        self.expectOutcome(result=SUCCESS, state_string='Compiled WebKit')
    509509        return self.runStep()
    510510
    … …  
    521521            + 2,
    522522        )
    523         self.expectOutcome(result=FAILURE, state_string='compiled (failure)')
     523        self.expectOutcome(result=FAILURE, state_string='Compiled WebKit (failure)')
    524524        return self.runStep()
    525525
    … …  
    529529        self.setProperty('configuration', 'release')
    530530        self.expectHidden(True)
    531         self.expectOutcome(result=SKIPPED, state_string='compiled (skipped)')
     531        self.expectOutcome(result=SKIPPED, state_string='Compiled WebKit (skipped)')
    532532        return self.runStep()
    533533
    … …  
    551551            + 0,
    552552        )
    553         self.expectOutcome(result=SUCCESS, state_string='compiled')
     553        self.expectOutcome(result=SUCCESS, state_string='Compiled JSC')
    554554        return self.runStep()
    555555
    … …  
    565565            + 2,
    566566        )
    567         self.expectOutcome(result=FAILURE, state_string='compiled (failure)')
     567        self.expectOutcome(result=FAILURE, state_string='Compiled JSC (failure)')
    568568        return self.runStep()
    569569
    … …  
    588588            + 0,
    589589        )
    590         self.expectOutcome(result=SUCCESS, state_string='compiled')
     590        self.expectOutcome(result=SUCCESS, state_string='Compiled JSC')
    591591        return self.runStep()
    592592
    … …  
    603603            + 2,
    604604        )
    605         self.expectOutcome(result=FAILURE, state_string='compiled (failure)')
     605        self.expectOutcome(result=FAILURE, state_string='Compiled JSC (failure)')
    606606        return self.runStep()
    607607
    … …  
    611611        self.setProperty('configuration', 'debug')
    612612        self.expectHidden(True)
    613         self.expectOutcome(result=SKIPPED, state_string='compiled (skipped)')
     613        self.expectOutcome(result=SKIPPED, state_string='Compiled JSC (skipped)')
    614614        return self.runStep()
    615615
    … …  
    842842            + 0,
    843843        )
    844         self.expectOutcome(result=SUCCESS, state_string='archived built product')
     844        self.expectOutcome(result=SUCCESS, state_string='Archived built product')
    845845        return self.runStep()
    846846
    … …  
    856856            + 2,
    857857        )
    858         self.expectOutcome(result=FAILURE, state_string='archived built product (failure)')
     858        self.expectOutcome(result=FAILURE, state_string='Archived built product (failure)')
    859859        return self.runStep()
    860860
    … …  
    908908            + 0,
    909909        )
    910         self.expectOutcome(result=SUCCESS, state_string='extracted built product')
     910        self.expectOutcome(result=SUCCESS, state_string='Extracted built product')
    911911        return self.runStep()
    912912
    … …  
    922922            + 2,
    923923        )
    924         self.expectOutcome(result=FAILURE, state_string='extracted built product (failure)')
     924        self.expectOutcome(result=FAILURE, state_string='Extracted built product (failure)')
    925925        return self.runStep()
    926926
    … …  
    11501150            + 0,
    11511151        )
    1152         self.expectOutcome(result=SUCCESS, state_string='archived test results')
     1152        self.expectOutcome(result=SUCCESS, state_string='Archived test results')
    11531153        return self.runStep()
    11541154
    … …  
    11651165            + 2,
    11661166        )
    1167         self.expectOutcome(result=FAILURE, state_string='archived test results (failure)')
     1167        self.expectOutcome(result=FAILURE, state_string='Archived test results (failure)')
    11681168        return self.runStep()
    11691169
    … …  
    11961196        self.expectUploadedFile('public_html/results/macOS-Sierra-Release-WK2-Tests-EWS/r1234-12.zip')
    11971197
    1198         self.expectOutcome(result=SUCCESS, state_string='uploading layout-test-results.zip')
     1198        self.expectOutcome(result=SUCCESS, state_string='Uploaded test results')
    11991199        return self.runStep()
    12001200
    … …  
    12221222            + 0,
    12231223        )
    1224         self.expectOutcome(result=SUCCESS, state_string='uploaded results')
     1224        self.expectOutcome(result=SUCCESS, state_string='Extracted test results')
    12251225        self.expectAddedURLs([call('view layout test results', '/results/test/r2468_ab1a28b4feee0d42973c7c05335b35bca927e974 (1)/results.html')])
    12261226        return self.runStep()

  • trunk/Tools/ChangeLog

    r242967 r242969  
     12019-03-14  Aakash Jain  <aakash_jain@apple.com>
     2
     3        [ews-build] Make descriptionDone messages more readable
     4        https://bugs.webkit.org/show_bug.cgi?id=195760
     5
     6        Reviewed by Lucas Forschler.
     7
     8        * BuildSlaveSupport/ews-build/steps.py:
     9        * BuildSlaveSupport/ews-build/steps_unittest.py:
     10
    1112019-03-14  Aakash Jain  <aakash_jain@apple.com>
    212
Note: See TracChangeset for help on using the changeset viewer.