Changeset 243072 in webkit


Ignore:
Timestamp:
Mar 18, 2019 9:52:45 AM (5 years ago)
Author:
eric.carlson@apple.com
Message:

Change some logging levels
​https://bugs.webkit.org/show_bug.cgi?id=195861
<rdar://problem/48961669>

Reviewed by Jer Noble.

  • Modules/mediastream/RTCPeerConnection.cpp:

(WebCore::RTCPeerConnection::dispatchEvent):

  • Modules/webaudio/AudioNode.cpp:

(WebCore::AudioNode::addInput):
(WebCore::AudioNode::addOutput):
(WebCore::AudioNode::connect):
(WebCore::AudioNode::disconnect):

  • Modules/webaudio/AudioParam.cpp:

(WebCore::AudioParam::connect):
(WebCore::AudioParam::disconnect):

  • Modules/webaudio/WaveShaperNode.cpp:

(WebCore::WaveShaperNode::setOversample):

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::canPlayType const):
(WebCore::HTMLMediaElement::seekTask):
(WebCore::HTMLMediaElement::dispatchEvent):
(WebCore::HTMLMediaElement::ensureMediaControlsInjectedScript):
(WebCore::HTMLMediaElement::didAddUserAgentShadowRoot):
(WebCore::HTMLMediaElement::setMediaControlsDependOnPageScaleFactor):

  • html/track/InbandGenericTextTrack.cpp:

(WebCore::InbandGenericTextTrack::addGenericCue):
(WebCore::InbandGenericTextTrack::removeGenericCue):
(WebCore::InbandGenericTextTrack::newCuesParsed):

  • html/track/InbandWebVTTTextTrack.cpp:

(WebCore::InbandWebVTTTextTrack::newCuesParsed):

  • html/track/LoadableTextTrack.cpp:

(WebCore::LoadableTextTrack::newCuesAvailable):

  • html/track/TextTrack.cpp:

(WebCore::TextTrack::removeCue):

  • inspector/agents/WebConsoleAgent.cpp:

(WebCore::WebConsoleAgent::getLoggingChannels):

  • platform/graphics/avfoundation/InbandTextTrackPrivateAVF.cpp:

(WebCore::InbandTextTrackPrivateAVF::processAttributedStrings):
(WebCore::InbandTextTrackPrivateAVF::removeCompletedCues):
(WebCore::InbandTextTrackPrivateAVF::processNativeSamples):

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::createImageForTimeInRect):
(WebCore::MediaPlayerPrivateAVFoundationObjC::updateLastImage):
(WebCore::MediaPlayerPrivateAVFoundationObjC::metadataDidArrive):

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:

(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::seekWithTolerance):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::seekInternal):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::isCurrentPlaybackTargetWireless const):

Location:
trunk/Source/WebCore
Files:
14 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebCore/ChangeLog

    r243070 r243072  
     12019-03-18  Eric Carlson  <eric.carlson@apple.com>
     2
     3        Change some logging levels
     4        https://bugs.webkit.org/show_bug.cgi?id=195861
     5        <rdar://problem/48961669>
     6
     7        Reviewed by Jer Noble.
     8
     9        * Modules/mediastream/RTCPeerConnection.cpp:
     10        (WebCore::RTCPeerConnection::dispatchEvent):
     11        * Modules/webaudio/AudioNode.cpp:
     12        (WebCore::AudioNode::addInput):
     13        (WebCore::AudioNode::addOutput):
     14        (WebCore::AudioNode::connect):
     15        (WebCore::AudioNode::disconnect):
     16        * Modules/webaudio/AudioParam.cpp:
     17        (WebCore::AudioParam::connect):
     18        (WebCore::AudioParam::disconnect):
     19        * Modules/webaudio/WaveShaperNode.cpp:
     20        (WebCore::WaveShaperNode::setOversample):
     21        * html/HTMLMediaElement.cpp:
     22        (WebCore::HTMLMediaElement::canPlayType const):
     23        (WebCore::HTMLMediaElement::seekTask):
     24        (WebCore::HTMLMediaElement::dispatchEvent):
     25        (WebCore::HTMLMediaElement::ensureMediaControlsInjectedScript):
     26        (WebCore::HTMLMediaElement::didAddUserAgentShadowRoot):
     27        (WebCore::HTMLMediaElement::setMediaControlsDependOnPageScaleFactor):
     28        * html/track/InbandGenericTextTrack.cpp:
     29        (WebCore::InbandGenericTextTrack::addGenericCue):
     30        (WebCore::InbandGenericTextTrack::removeGenericCue):
     31        (WebCore::InbandGenericTextTrack::newCuesParsed):
     32        * html/track/InbandWebVTTTextTrack.cpp:
     33        (WebCore::InbandWebVTTTextTrack::newCuesParsed):
     34        * html/track/LoadableTextTrack.cpp:
     35        (WebCore::LoadableTextTrack::newCuesAvailable):
     36        * html/track/TextTrack.cpp:
     37        (WebCore::TextTrack::removeCue):
     38        * inspector/agents/WebConsoleAgent.cpp:
     39        (WebCore::WebConsoleAgent::getLoggingChannels):
     40        * platform/graphics/avfoundation/InbandTextTrackPrivateAVF.cpp:
     41        (WebCore::InbandTextTrackPrivateAVF::processAttributedStrings):
     42        (WebCore::InbandTextTrackPrivateAVF::removeCompletedCues):
     43        (WebCore::InbandTextTrackPrivateAVF::processNativeSamples):
     44        * platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
     45        (WebCore::MediaPlayerPrivateAVFoundationObjC::createImageForTimeInRect):
     46        (WebCore::MediaPlayerPrivateAVFoundationObjC::updateLastImage):
     47        (WebCore::MediaPlayerPrivateAVFoundationObjC::metadataDidArrive):
     48        * platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:
     49        (WebCore::MediaPlayerPrivateMediaSourceAVFObjC::seekWithTolerance):
     50        (WebCore::MediaPlayerPrivateMediaSourceAVFObjC::seekInternal):
     51        (WebCore::MediaPlayerPrivateMediaSourceAVFObjC::isCurrentPlaybackTargetWireless const):
     52
    1532019-03-15  Antoine Quint  <graouts@apple.com>
    254

  • trunk/Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp

    r242886 r243072  
    581581void RTCPeerConnection::dispatchEvent(Event& event)
    582582{
    583     DEBUG_LOG(LOGIDENTIFIER, "dispatching '", event.type(), "'");
     583    INFO_LOG(LOGIDENTIFIER, "dispatching '", event.type(), "'");
    584584    EventTarget::dispatchEvent(event);
    585585}

  • trunk/Source/WebCore/Modules/webaudio/AudioNode.cpp

    r242734 r243072  
    164164{
    165165    ASSERT(isMainThread());
    166     DEBUG_LOG(LOGIDENTIFIER, input->node()->nodeType());
     166    INFO_LOG(LOGIDENTIFIER, input->node()->nodeType());
    167167    m_inputs.append(WTFMove(input));
    168168}
    … …  
    171171{
    172172    ASSERT(isMainThread());
    173     DEBUG_LOG(LOGIDENTIFIER, output->node()->nodeType());
     173    INFO_LOG(LOGIDENTIFIER, output->node()->nodeType());
    174174    m_outputs.append(WTFMove(output));
    175175}
    … …  
    222222    ASSERT(isMainThread());
    223223
    224     DEBUG_LOG(LOGIDENTIFIER, param.name(), ", output = ", outputIndex);
     224    INFO_LOG(LOGIDENTIFIER, param.name(), ", output = ", outputIndex);
    225225
    226226    if (outputIndex >= numberOfOutputs())
    … …  
    246246
    247247    auto* output = this->output(outputIndex);
    248     DEBUG_LOG(LOGIDENTIFIER, output->node()->nodeType());
     248    INFO_LOG(LOGIDENTIFIER, output->node()->nodeType());
    249249
    250250    output->disconnectAll();

  • trunk/Source/WebCore/Modules/webaudio/AudioParam.cpp

    r242734 r243072  
    195195        return;
    196196
    197     DEBUG_LOG(LOGIDENTIFIER, output->node()->nodeType());
     197    INFO_LOG(LOGIDENTIFIER, output->node()->nodeType());
    198198
    199199    output->addParam(this);
    … …  
    209209        return;
    210210
    211     DEBUG_LOG(LOGIDENTIFIER, output->node()->nodeType());
     211    INFO_LOG(LOGIDENTIFIER, output->node()->nodeType());
    212212
    213213    if (m_outputs.remove(output)) {

  • trunk/Source/WebCore/Modules/webaudio/WaveShaperNode.cpp

    r242734 r243072  
    7272{
    7373    ASSERT(isMainThread());
    74     DEBUG_LOG(LOGIDENTIFIER, type);
     74    INFO_LOG(LOGIDENTIFIER, type);
    7575
    7676    // Synchronize with any graph changes or changes to channel configuration.

  • trunk/Source/WebCore/html/HTMLMediaElement.cpp

    r243033 r243072  
    11601160    }
    11611161
    1162     DEBUG_LOG(LOGIDENTIFIER, "[", mimeType, "] -> ", canPlay);
     1162    INFO_LOG(LOGIDENTIFIER, mimeType, ": ", canPlay);
    11631163
    11641164    return canPlay;
    … …  
    30793079        MediaTime mediaTime = m_player->mediaTimeForTimeValue(time);
    30803080        if (time != mediaTime)
    3081             DEBUG_LOG(LOGIDENTIFIER, time, " media timeline equivalent is ", mediaTime);
     3081            INFO_LOG(LOGIDENTIFIER, time, " media timeline equivalent is ", mediaTime);
    30823082    }
    30833083
    … …  
    59155915void HTMLMediaElement::dispatchEvent(Event& event)
    59165916{
    5917     DEBUG_LOG(LOGIDENTIFIER, "dispatching '", event.type(), "'");
     5917    DEBUG_LOG(LOGIDENTIFIER, event.type());
    59185918
    59195919    HTMLElement::dispatchEvent(event);
    … …  
    72717271bool HTMLMediaElement::ensureMediaControlsInjectedScript()
    72727272{
    7273     DEBUG_LOG(LOGIDENTIFIER);
     7273    INFO_LOG(LOGIDENTIFIER);
    72747274
    72757275    Page* page = document().page();
    … …  
    73457345void HTMLMediaElement::didAddUserAgentShadowRoot(ShadowRoot& root)
    73467346{
    7347     DEBUG_LOG(LOGIDENTIFIER);
     7347    INFO_LOG(LOGIDENTIFIER);
    73487348
    73497349    if (!ensureMediaControlsInjectedScript())
    … …  
    74237423void HTMLMediaElement::setMediaControlsDependOnPageScaleFactor(bool dependsOnPageScale)
    74247424{
    7425     DEBUG_LOG(LOGIDENTIFIER, "MediaElement::setMediaControlsDependPageScaleFactor", dependsOnPageScale);
     7425    INFO_LOG(LOGIDENTIFIER, dependsOnPageScale);
    74267426
    74277427    if (document().settings().mediaControlsScaleWithPageZoom()) {
    7428         DEBUG_LOG(LOGIDENTIFIER, "MediaElement::setMediaControlsDependPageScaleFactor", "forced to false by Settings value");
     7428        INFO_LOG(LOGIDENTIFIER, "forced to false by Settings value");
    74297429        m_mediaControlsDependOnPageScaleFactor = false;
    74307430        return;

  • trunk/Source/WebCore/html/track/InbandGenericTextTrack.cpp

    r237187 r243072  
    126126    updateCueFromCueData(cue.get(), cueData);
    127127    if (hasCue(cue.ptr(), TextTrackCue::IgnoreDuration)) {
    128         DEBUG_LOG(LOGIDENTIFIER, "ignoring already added cue: ", cue.get());
     128        INFO_LOG(LOGIDENTIFIER, "ignoring already added cue: ", cue.get());
    129129        return;
    130130    }
    131131
    132     DEBUG_LOG(LOGIDENTIFIER, "added cue: ", cue.get());
     132    INFO_LOG(LOGIDENTIFIER, "added cue: ", cue.get());
    133133
    134134    if (cueData.status() != GenericCueData::Complete)
    … …  
    154154    auto cue = makeRefPtr(m_cueMap.find(cueData));
    155155    if (cue) {
    156         DEBUG_LOG(LOGIDENTIFIER, *cue);
     156        INFO_LOG(LOGIDENTIFIER, *cue);
    157157        removeCue(*cue);
    158158    } else
    159         DEBUG_LOG(LOGIDENTIFIER, "UNABLE to find cue: ", cueData);
     159        INFO_LOG(LOGIDENTIFIER, "UNABLE to find cue: ", cueData);
    160160
    161161}
    … …  
    195195
    196196        if (hasCue(vttCue.ptr(), TextTrackCue::IgnoreDuration)) {
    197             DEBUG_LOG(LOGIDENTIFIER, "ignoring already added cue: ", vttCue.get());
     197            INFO_LOG(LOGIDENTIFIER, "ignoring already added cue: ", vttCue.get());
    198198            return;
    199199        }
    200200
    201         DEBUG_LOG(LOGIDENTIFIER, vttCue.get());
     201        INFO_LOG(LOGIDENTIFIER, vttCue.get());
    202202
    203203        addCue(WTFMove(vttCue));

  • trunk/Source/WebCore/html/track/InbandWebVTTTextTrack.cpp

    r237187 r243072  
    7373        auto vttCue = VTTCue::create(*scriptExecutionContext(), *cueData);
    7474        if (hasCue(vttCue.ptr(), TextTrackCue::IgnoreDuration)) {
    75             DEBUG_LOG(LOGIDENTIFIER, "ignoring already added cue: ", vttCue.get());
     75            INFO_LOG(LOGIDENTIFIER, "ignoring already added cue: ", vttCue.get());
    7676            return;
    7777        }
    7878
    79         DEBUG_LOG(LOGIDENTIFIER, vttCue.get());
     79        INFO_LOG(LOGIDENTIFIER, vttCue.get());
    8080
    8181        addCue(WTFMove(vttCue));

  • trunk/Source/WebCore/html/track/LoadableTextTrack.cpp

    r237265 r243072  
    9999    for (auto& newCue : newCues) {
    100100        newCue->setTrack(this);
    101         DEBUG_LOG(LOGIDENTIFIER, *toVTTCue(newCue.get()));
     101        INFO_LOG(LOGIDENTIFIER, *toVTTCue(newCue.get()));
    102102        m_cues->add(newCue.releaseNonNull());
    103103    }

  • trunk/Source/WebCore/html/track/TextTrack.cpp

    r239427 r243072  
    338338        return Exception { InvalidStateError };
    339339
    340     DEBUG_LOG(LOGIDENTIFIER, cue);
     340    INFO_LOG(LOGIDENTIFIER, cue);
    341341
    342342    // 2. Remove cue from the method's TextTrack object's text track's text track list of cues.

  • trunk/Source/WebCore/inspector/agents/WebConsoleAgent.cpp

    r241729 r243072  
    7474            case WTFLogLevelError:
    7575            case WTFLogLevelWarning:
     76            case WTFLogLevelInfo:
    7677                level = Inspector::Protocol::Console::ChannelLevel::Basic;
    7778                break;
    78             case WTFLogLevelInfo:
    7979            case WTFLogLevelDebug:
    8080                level = Inspector::Protocol::Console::ChannelLevel::Verbose;

  • trunk/Source/WebCore/platform/graphics/avfoundation/InbandTextTrackPrivateAVF.cpp

    r237266 r243072  
    319319
    320320    if (count)
    321         DEBUG_LOG(LOGIDENTIFIER, "added ", count, count > 1 ? " cues" : " cue", " at time ", time);
     321        INFO_LOG(LOGIDENTIFIER, "added ", count, count > 1 ? " cues" : " cue", " at time ", time);
    322322
    323323    Vector<Ref<GenericCueData>> arrivingCues;
    … …  
    360360                        nonExtensionCues.append(WTFMove(arrivingCue));
    361361                    else
    362                         DEBUG_LOG(LOGIDENTIFIER, "found an extension cue ", *cueData);
     362                        INFO_LOG(LOGIDENTIFIER, "found an extension cue ", *cueData);
    363363                }
    364364
    … …  
    374374                    cueData->setStatus(GenericCueData::Complete);
    375375
    376                     DEBUG_LOG(LOGIDENTIFIER, "updating cue ", *cueData);
     376                    INFO_LOG(LOGIDENTIFIER, "updating cue ", *cueData);
    377377
    378378                    client()->updateGenericCue(*cueData);
    … …  
    380380                    // We have to assume that the implicit duration is invalid for cues delivered during a seek because the AVF decode pipeline may not
    381381                    // see every cue, so DO NOT update cue duration while seeking.
    382                     DEBUG_LOG(LOGIDENTIFIER, "ignoring cue delivered during seek ", *cueData);
     382                    INFO_LOG(LOGIDENTIFIER, "ignoring cue delivered during seek ", *cueData);
    383383                }
    384384            }
    … …  
    396396    for (auto& cueData : arrivingCues) {
    397397        m_cues.append(cueData.ptr());
    398         DEBUG_LOG(LOGIDENTIFIER, "adding cue ", cueData.get());
     398        INFO_LOG(LOGIDENTIFIER, "adding cue ", cueData.get());
    399399        client()->addGenericCue(cueData);
    400400    }
    … …  
    427427                continue;
    428428
    429             DEBUG_LOG(LOGIDENTIFIER, "removing cue ", *cue);
     429            INFO_LOG(LOGIDENTIFIER, "removing cue ", *cue);
    430430
    431431            m_cues.remove(currentCue);
    … …  
    502502        }
    503503
    504         DEBUG_LOG(LOGIDENTIFIER, "chunk  type = '", type.toString(), "', size = ", (size_t)boxLength);
     504        INFO_LOG(LOGIDENTIFIER, "chunk  type = '", type.toString(), "', size = ", (size_t)boxLength);
    505505
    506506        do {
    … …  
    530530            header.append("\n\n");
    531531
    532             DEBUG_LOG(LOGIDENTIFIER, "VTT header ", &header);
     532            INFO_LOG(LOGIDENTIFIER, "VTT header ", &header);
    533533            client()->parseWebVTTFileHeader(header.toString());
    534534            m_haveReportedVTTHeader = true;
    … …  
    538538            ISOWebVTTCue cueData = ISOWebVTTCue(presentationTime, duration);
    539539            cueData.read(view);
    540             DEBUG_LOG(LOGIDENTIFIER, "VTT cue data ", cueData);
     540            INFO_LOG(LOGIDENTIFIER, "VTT cue data ", cueData);
    541541            client()->parseWebVTTCueData(cueData);
    542542        }

  • trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm

    r241738 r243072  
    16761676
    16771677#if !RELEASE_LOG_DISABLED
    1678     DEBUG_LOG(LOGIDENTIFIER, "creating image took ", (MonotonicTime::now() - start).seconds());
     1678    INFO_LOG(LOGIDENTIFIER, "creating image took ", (MonotonicTime::now() - start).seconds());
    16791679#endif
    16801680
    … …  
    23582358
    23592359#if !RELEASE_LOG_DISABLED
    2360     DEBUG_LOG(LOGIDENTIFIER, "creating buffer took ", (MonotonicTime::now() - start).seconds());
     2360    INFO_LOG(LOGIDENTIFIER, "creating buffer took ", (MonotonicTime::now() - start).seconds());
    23612361#endif
    23622362#endif // HAVE(CORE_VIDEO)
    … …  
    31553155    m_currentMetaData = metadata && ![metadata isKindOfClass:[NSNull class]] ? metadata : nil;
    31563156
    3157     DEBUG_LOG(LOGIDENTIFIER, "adding ", m_currentMetaData ? [m_currentMetaData.get() count] : 0, " at time ", mediaTime);
     3157    INFO_LOG(LOGIDENTIFIER, "adding ", m_currentMetaData ? [m_currentMetaData.get() count] : 0, " at time ", mediaTime);
    31583158
    31593159#if ENABLE(DATACUE_VALUE)

  • trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm

    r242720 r243072  
    407407void MediaPlayerPrivateMediaSourceAVFObjC::seekWithTolerance(const MediaTime& time, const MediaTime& negativeThreshold, const MediaTime& positiveThreshold)
    408408{
    409     DEBUG_LOG(LOGIDENTIFIER, "time = ", time, ", negativeThreshold = ", negativeThreshold, ", positiveThreshold = ", positiveThreshold);
     409    INFO_LOG(LOGIDENTIFIER, "time = ", time, ", negativeThreshold = ", negativeThreshold, ", positiveThreshold = ", positiveThreshold);
    410410
    411411    m_seeking = true;
    … …  
    438438
    439439    MediaTime synchronizerTime = PAL::toMediaTime(CMTimebaseGetTime([m_synchronizer timebase]));
    440     DEBUG_LOG(LOGIDENTIFIER, "seekTime = ", m_lastSeekTime, ", synchronizerTime = ", synchronizerTime);
     440    INFO_LOG(LOGIDENTIFIER, "seekTime = ", m_lastSeekTime, ", synchronizerTime = ", synchronizerTime);
    441441
    442442    bool doesNotRequireSeek = synchronizerTime == m_lastSeekTime;
    … …  
    11641164
    11651165    auto hasTarget = m_shouldPlayToTarget && m_playbackTarget->hasActiveRoute();
    1166     DEBUG_LOG(LOGIDENTIFIER, hasTarget);
     1166    INFO_LOG(LOGIDENTIFIER, hasTarget);
    11671167    return hasTarget;
    11681168}
Note: See TracChangeset for help on using the changeset viewer.