Changeset 243156 in webkit

Timestamp:

Mar 19, 2019, 11:44:18 AM (7 years ago)

Author:

Chris Dumez

Message:

REGRESSION (r243094): internal media test fairplay-hls-error.html is failing
​https://bugs.webkit.org/show_bug.cgi?id=195954
<rdar://problem/49005981>

Reviewed by Geoffrey Garen.

TestController::resetStateToConsistentValues() tries to send a "reset" message to its
injected bundle. Part of the "reset" message sets the external hosts that we're allowed
to load. If there is no WebProcess yet when WKPagePostMessageToInjectedBundle() is called,
then this message does not get sent and the allowed hosts do not get set, causing this
test failure.

To address the issue, make sure we launch the initial process if necessary when
WebPageProxy::postMessageToInjectedBundle() is called, in order to maintain backward
compatibility.

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::postMessageToInjectedBundle):

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/WebPageProxy.cpp (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2019-03-19  Chris Dumez  <cdumez@apple.com>
+
+        REGRESSION (r243094): internal media test fairplay-hls-error.html is failing
+        https://bugs.webkit.org/show_bug.cgi?id=195954
+        <rdar://problem/49005981>
+
+        Reviewed by Geoffrey Garen.
+
+        TestController::resetStateToConsistentValues() tries to send a "reset" message to its
+        injected bundle. Part of the "reset" message sets the external hosts that we're allowed
+        to load. If there is no WebProcess yet when WKPagePostMessageToInjectedBundle() is called,
+        then this message does not get sent and the allowed hosts do not get set, causing this
+        test failure.
+
+        To address the issue, make sure we launch the initial process if necessary when
+        WebPageProxy::postMessageToInjectedBundle() is called, in order to maintain backward
+        compatibility.
+
+        * UIProcess/WebPageProxy.cpp:
+        (WebKit::WebPageProxy::postMessageToInjectedBundle):
+
 2019-03-19  Chris Dumez  <cdumez@apple.com>
 

trunk/Source/WebKit/UIProcess/WebPageProxy.cpp

@@ -5816 +5816 @@
 void WebPageProxy::postMessageToInjectedBundle(const String& messageName, API::Object* messageBody)
 {
+    // For backward-compatibility, make sure we launch the initial process if the client asks to post a message to its injected bundle because doing a load.
+    launchInitialProcessIfNecessary();
+
     process().send(Messages::WebPage::PostInjectedBundleMessage(messageName, UserData(process().transformObjectsToHandles(messageBody).get())), m_pageID);
 }