Changeset 243208 in webkit

Timestamp:

Mar 20, 2019, 9:28:16 AM (7 years ago)

Author:

Devin Rousso

Message:

Web Inspector: changes to CSS resources only take affect once editing stops
​https://bugs.webkit.org/show_bug.cgi?id=195774
<rdar://problem/48905413>

Reviewed by Timothy Hatcher.

• UserInterface/Controllers/CSSManager.js:

(WI.CSSManager.prototype._resourceContentDidChange.applyStyleSheetChanges.styleSheetFound):
(WI.CSSManager.prototype._resourceContentDidChange):
(WI.CSSManager.prototype._updateResourceContent.fetchedStyleSheetContent):
(WI.CSSManager.prototype._updateResourceContent):
Use a Throttler instead of a 500ms debounce.

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Controllers/CSSManager.js (modified) (4 diffs)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2019-03-20  Devin Rousso  <drousso@apple.com>
+
+        Web Inspector: changes to CSS resources only take affect once editing stops
+        https://bugs.webkit.org/show_bug.cgi?id=195774
+        <rdar://problem/48905413>
+
+        Reviewed by Timothy Hatcher.
+
+        * UserInterface/Controllers/CSSManager.js:
+        (WI.CSSManager.prototype._resourceContentDidChange.applyStyleSheetChanges.styleSheetFound):
+        (WI.CSSManager.prototype._resourceContentDidChange):
+        (WI.CSSManager.prototype._updateResourceContent.fetchedStyleSheetContent):
+        (WI.CSSManager.prototype._updateResourceContent):
+        Use a `Throttler` instead of a 500ms debounce.
+
 2019-03-20  Devin Rousso  <drousso@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/Controllers/CSSManager.js

@@ -642 +642 @@
             function styleSheetFound(styleSheet)
             {
-                resource.__pendingChangeTimeout = undefined;
+                resource.__pendingChangeTimeout.cancel();
 
                 console.assert(styleSheet);
@@ -658 +658 @@
         }
 
-        if (resource.__pendingChangeTimeout)
-            clearTimeout(resource.__pendingChangeTimeout);
-        resource.__pendingChangeTimeout = setTimeout(applyStyleSheetChanges.bind(this), 500);
+        if (!resource.__pendingChangeTimeout)
+            resource.__pendingChangeTimeout = new Throttler(applyStyleSheetChanges.bind(this), 100);
+        resource.__pendingChangeTimeout.fire();
     }
 
@@ -669 +669 @@
         function fetchedStyleSheetContent(parameters)
         {
+            styleSheet.__pendingChangeTimeout.cancel();
+
             let representedObject = parameters.sourceCode;
-            representedObject.__pendingChangeTimeout = undefined;
 
             console.assert(representedObject.url);
@@ -717 +718 @@
         }
 
-        if (styleSheet.__pendingChangeTimeout)
-            clearTimeout(styleSheet.__pendingChangeTimeout);
-        styleSheet.__pendingChangeTimeout = setTimeout(applyStyleSheetChanges.bind(this), 500);
+        if (!styleSheet.__pendingChangeTimeout)
+            styleSheet.__pendingChangeTimeout = new Throttler(applyStyleSheetChanges.bind(this), 100);
+        styleSheet.__pendingChangeTimeout.fire();
     }
 };