Changeset 243220 in webkit

Timestamp:

Mar 20, 2019, 11:58:04 AM (7 years ago)

Author:

Devin Rousso

Message:

Web Inspector: Console: add a setting for controlling auto-expansion of Trace messages
​https://bugs.webkit.org/show_bug.cgi?id=195690

Reviewed by Timothy Hatcher.

• UserInterface/Views/ConsoleMessageView.js:

(WI.ConsoleMessageView.prototype._appendStackTrace):

• UserInterface/Base/Setting.js:
• UserInterface/Views/SettingsTabContentView.js:

(WI.SettingsTabContentView.prototype._createGeneralSettingsView):

• Localizations/en.lproj/localizedStrings.js:

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• Localizations/en.lproj/localizedStrings.js (modified) (2 diffs)
• UserInterface/Base/Setting.js (modified) (1 diff)
• UserInterface/Views/ConsoleMessageView.js (modified) (1 diff)
• UserInterface/Views/SettingsTabContentView.js (modified) (1 diff)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2019-03-20  Devin Rousso  <drousso@apple.com>
+
+        Web Inspector: Console: add a setting for controlling auto-expansion of Trace messages
+        https://bugs.webkit.org/show_bug.cgi?id=195690
+
+        Reviewed by Timothy Hatcher.
+
+        * UserInterface/Views/ConsoleMessageView.js:
+        (WI.ConsoleMessageView.prototype._appendStackTrace):
+
+        * UserInterface/Base/Setting.js:
+        * UserInterface/Views/SettingsTabContentView.js:
+        (WI.SettingsTabContentView.prototype._createGeneralSettingsView):
+
+        * Localizations/en.lproj/localizedStrings.js:
+
 2019-03-20  Devin Rousso  <drousso@apple.com>
 

trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js

@@ -146 +146 @@
 localizedStrings["Auto - %s"] = "Auto - %s";
 localizedStrings["Auto Increment"] = "Auto Increment";
+localizedStrings["Auto-expand Traces"] = "Auto-expand Traces";
 localizedStrings["Automatically continue after evaluating"] = "Automatically continue after evaluating";
 localizedStrings["Available Style Sheets"] = "Available Style Sheets";
@@ -264 +265 @@
 localizedStrings["Console cleared at %s"] = "Console cleared at %s";
 localizedStrings["Console opened at %s"] = "Console opened at %s";
+localizedStrings["Console:"] = "Console:";
 localizedStrings["Containing"] = "Containing";
 localizedStrings["Content"] = "Content";

trunk/Source/WebInspectorUI/UserInterface/Base/Setting.js

@@ -128 +128 @@
     canvasRecordingAutoCaptureEnabled: new WI.Setting("canvas-recording-auto-capture-enabled", false),
     canvasRecordingAutoCaptureFrameCount: new WI.Setting("canvas-recording-auto-capture-frame-count", 1),
+    consoleAutoExpandTrace: new WI.Setting("console-auto-expand-trace", true),
     cssChangesPerNode: new WI.Setting("css-changes-per-node", false),
     clearLogOnNavigate: new WI.Setting("clear-log-on-navigate", true),

trunk/Source/WebInspectorUI/UserInterface/Views/ConsoleMessageView.js

@@ -417 +417 @@
         this._makeExpandable();
 
-        // Auto-expand for console.trace.
-        if (this._message.type === WI.ConsoleMessage.MessageType.Trace)
+        if (this._message.type === WI.ConsoleMessage.MessageType.Trace && WI.settings.consoleAutoExpandTrace.value)
             this.expand();
 

trunk/Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js

@@ -209 +209 @@
         generalSettingsView.addSetting(WI.UIString("Debugger:"), WI.settings.showScopeChainOnPause, WI.UIString("Show Scope Chain on pause"));
         generalSettingsView.addSetting(WI.UIString("Source maps:"), WI.settings.sourceMapsEnabled, WI.UIString("Enable source maps"));
+        generalSettingsView.addSetting(WI.UIString("Console:"), WI.settings.consoleAutoExpandTrace, WI.UIString("Auto-expand Traces"));
 
         generalSettingsView.addSeparator();