Changeset 243231 in webkit

Timestamp:

Mar 20, 2019, 1:18:49 PM (7 years ago)

Author:

commit-queue@webkit.org

Message:

[GTK] REGRESSION(r243094): crash when launching minibrowser
​https://bugs.webkit.org/show_bug.cgi?id=195951

Patch by Carlos Garcia Campos <​cgarcia@igalia.com> on 2019-03-20
Reviewed by Joseph Pecoraro.

Always return the inspector from WebPageProxy::inspector() when the page hasn't been closed. The inspector is
created in WebPageProxy constructor and it's safe to use even before a process has been launched, because
m_inspectedPage is null-checked everywhere.

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::inspector const):

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/WebPageProxy.cpp (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2019-03-20  Carlos Garcia Campos  <cgarcia@igalia.com>
+
+        [GTK] REGRESSION(r243094): crash when launching minibrowser
+        https://bugs.webkit.org/show_bug.cgi?id=195951
+
+        Reviewed by Joseph Pecoraro.
+
+        Always return the inspector from WebPageProxy::inspector() when the page hasn't been closed. The inspector is
+        created in WebPageProxy constructor and it's safe to use even before a process has been launched, because
+        m_inspectedPage is null-checked everywhere.
+
+        * UIProcess/WebPageProxy.cpp:
+        (WebKit::WebPageProxy::inspector const):
+
 2019-03-20  Keith Rollin  <krollin@apple.com>
 

trunk/Source/WebKit/UIProcess/WebPageProxy.cpp

@@ -5529 +5529 @@
 WebInspectorProxy* WebPageProxy::inspector() const
 {
-    if (isClosed() || !hasRunningProcess())
+    if (isClosed())
         return nullptr;
     return m_inspector.get();