Changeset 243236 in webkit

Timestamp:

Mar 20, 2019, 1:37:01 PM (7 years ago)

Author:

rmorisset@apple.com

Message:

DFGNodeAllocator.h is dead code
​https://bugs.webkit.org/show_bug.cgi?id=196019

Reviewed by Yusuke Suzuki.

As explained by Yusuke on IRC, the comment on DFG::Node saying that it cannot have a destructor is obsolete since ​https://trac.webkit.org/changeset/216815/webkit.
This patch removes both the comment and DFGNodeAllocator.h that that patch forgot to remove.

• dfg/DFGNode.h:

(JSC::DFG::Node::dumpChildren):

• dfg/DFGNodeAllocator.h: Removed.

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• dfg/DFGNode.h (modified) (1 diff)
• dfg/DFGNodeAllocator.h (deleted)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2019-03-20  Robin Morisset  <rmorisset@apple.com>
+
+        DFGNodeAllocator.h is dead code
+        https://bugs.webkit.org/show_bug.cgi?id=196019
+
+        Reviewed by Yusuke Suzuki.
+
+        As explained by Yusuke on IRC, the comment on DFG::Node saying that it cannot have a destructor is obsolete since https://trac.webkit.org/changeset/216815/webkit.
+        This patch removes both the comment and DFGNodeAllocator.h that that patch forgot to remove.
+
+        * dfg/DFGNode.h:
+        (JSC::DFG::Node::dumpChildren):
+        * dfg/DFGNodeAllocator.h: Removed.
+
 2019-03-20  Robin Morisset  <rmorisset@apple.com>
 

trunk/Source/JavaScriptCore/dfg/DFGNode.h

@@ -2888 +2888 @@
         out.printf(", @%u", child3()->index());
     }
-    
-    // NB. This class must have a trivial destructor.
 
     NodeOrigin origin;