Changeset 243238 in webkit

Timestamp:

Mar 20, 2019, 2:22:08 PM (7 years ago)

Author:

Joseph Pecoraro

Message:

Web Inspector: Timelines - Export fails for MediaTimelineRecords with originator DOM Node - Cannot serialize cyclic structure
​https://bugs.webkit.org/show_bug.cgi?id=196027

Reviewed by Timothy Hatcher.

• UserInterface/Models/MediaTimelineRecord.js:

(WI.MediaTimelineRecord.prototype.toJSON):
Remove the originator since that is a WI.DOMNode and cannot
be JSON serialized.

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Models/MediaTimelineRecord.js (modified) (1 diff)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2019-03-20  Joseph Pecoraro  <pecoraro@apple.com>
+
+        Web Inspector: Timelines - Export fails for MediaTimelineRecords with originator DOM Node - Cannot serialize cyclic structure
+        https://bugs.webkit.org/show_bug.cgi?id=196027
+
+        Reviewed by Timothy Hatcher.
+
+        * UserInterface/Models/MediaTimelineRecord.js:
+        (WI.MediaTimelineRecord.prototype.toJSON):
+        Remove the originator since that is a WI.DOMNode and cannot
+        be JSON serialized.
+
 2019-03-20  Devin Rousso  <drousso@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/Models/MediaTimelineRecord.js

@@ -50 +50 @@
         // FIXME: DOMNode
 
+        // Don't include the DOMEvent's originator.
+        let domEvent = this._domEvent;
+        if (domEvent && domEvent.originator) {
+            domEvent = Object.shallowCopy(domEvent);
+            domEvent.originator = undefined;
+        }
+
         return {
             type: this.type,
             eventType: this._eventType,
             timestamp: this.startTime,
-            domEvent: this._domEvent,
+            domEvent,
             isLowPower: this._isLowPower,
         };