Changeset 243248 in webkit

Timestamp:

Mar 20, 2019, 3:48:04 PM (7 years ago)

Author:

dbates@webkit.org

Message:

REGRESSION (r243153): [iOS] TestWebKitAPI.FocusPreservationTests.ChangingFocusedNodeResetsFocusPreservationState is failing
​https://bugs.webkit.org/show_bug.cgi?id=196031
<rdar://problem/49078172>

Reviewed by Tim Horton.

The test incorrectly assumes that calling -[WKWebView resignFirstResponder] is identical to dismissing the
<select> picker. This is no longer the case following r243135. Instead use testing SPI that invokes that
same code path used when the Done button is pressed to dismiss the <select> picker.

• TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:

(TestWebKitAPI::TEST):

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• TestWebKitAPI/Tests/ios/FocusPreservationTests.mm (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2019-03-20  Daniel Bates  <dabates@apple.com>
+
+        REGRESSION (r243153): [iOS] TestWebKitAPI.FocusPreservationTests.ChangingFocusedNodeResetsFocusPreservationState is failing
+        https://bugs.webkit.org/show_bug.cgi?id=196031
+        <rdar://problem/49078172>
+
+        Reviewed by Tim Horton.
+
+        The test incorrectly assumes that calling -[WKWebView resignFirstResponder] is identical to dismissing the
+        <select> picker. This is no longer the case following r243135. Instead use testing SPI that invokes that
+        same code path used when the Done button is pressed to dismiss the <select> picker.
+
+        * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
+        (TestWebKitAPI::TEST):
+
 2019-03-20  Chris Dumez  <cdumez@apple.com>
 

trunk/Tools/TestWebKitAPI/Tests/ios/FocusPreservationTests.mm

@@ -97 +97 @@
     EXPECT_NOT_NULL(webView.textInputContentView.inputView);
     [webView selectFormAccessoryPickerRow:1];
-    EXPECT_TRUE([webView resignFirstResponder]);
+    [webView dismissFormAccessoryView];
     EXPECT_FALSE([webView stringByEvaluatingJavaScript:@"document.activeElement == document.querySelector('select')"].boolValue);
     EXPECT_EQ(1, [webView stringByEvaluatingJavaScript:@"document.querySelector('select').selectedIndex"].intValue);