Changeset 243323 in webkit

Timestamp:

Mar 21, 2019, 1:47:34 PM (7 years ago)

Author:

Michael Catanzaro

Message:

Unreviewed, more clang 3.8 build fixes
​https://bugs.webkit.org/show_bug.cgi?id=195947
<rdar://problem/49069219>

In the spirit of making our code worse to please old compilers....

• bindings/ScriptValue.cpp:

(Inspector::jsToInspectorValue):

• bytecode/GetterSetterAccessCase.cpp:

(JSC::GetterSetterAccessCase::create):
(JSC::GetterSetterAccessCase::clone const):

• bytecode/InstanceOfAccessCase.cpp:

(JSC::InstanceOfAccessCase::clone const):

• bytecode/IntrinsicGetterAccessCase.cpp:

(JSC::IntrinsicGetterAccessCase::clone const):

• bytecode/ModuleNamespaceAccessCase.cpp:

(JSC::ModuleNamespaceAccessCase::clone const):

• bytecode/ProxyableAccessCase.cpp:

(JSC::ProxyableAccessCase::clone const):

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• bindings/ScriptValue.cpp (modified) (2 diffs)
• bytecode/GetterSetterAccessCase.cpp (modified) (3 diffs)
• bytecode/InstanceOfAccessCase.cpp (modified) (1 diff)
• bytecode/IntrinsicGetterAccessCase.cpp (modified) (1 diff)
• bytecode/ModuleNamespaceAccessCase.cpp (modified) (1 diff)
• bytecode/ProxyableAccessCase.cpp (modified) (1 diff)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2019-03-21  Michael Catanzaro  <mcatanzaro@igalia.com>
+
+        Unreviewed, more clang 3.8 build fixes
+        https://bugs.webkit.org/show_bug.cgi?id=195947
+        <rdar://problem/49069219>
+
+        In the spirit of making our code worse to please old compilers....
+
+        * bindings/ScriptValue.cpp:
+        (Inspector::jsToInspectorValue):
+        * bytecode/GetterSetterAccessCase.cpp:
+        (JSC::GetterSetterAccessCase::create):
+        (JSC::GetterSetterAccessCase::clone const):
+        * bytecode/InstanceOfAccessCase.cpp:
+        (JSC::InstanceOfAccessCase::clone const):
+        * bytecode/IntrinsicGetterAccessCase.cpp:
+        (JSC::IntrinsicGetterAccessCase::clone const):
+        * bytecode/ModuleNamespaceAccessCase.cpp:
+        (JSC::ModuleNamespaceAccessCase::clone const):
+        * bytecode/ProxyableAccessCase.cpp:
+        (JSC::ProxyableAccessCase::clone const):
+
 2019-03-21  Yusuke Suzuki  <ysuzuki@apple.com>
 

trunk/Source/JavaScriptCore/bindings/ScriptValue.cpp

@@ -75 +75 @@
                 inspectorArray->pushValue(WTFMove(elementValue));
             }
-            return inspectorArray;
+            return RefPtr<JSON::Value> { WTFMove(inspectorArray) };
         }
         VM& vm = scriptState.vm();
@@ -88 +88 @@
             inspectorObject->setValue(name.string(), WTFMove(inspectorValue));
         }
-        return inspectorObject;
+        return RefPtr<JSON::Value> { WTFMove(inspectorObject) };
     }
 

trunk/Source/JavaScriptCore/bytecode/GetterSetterAccessCase.cpp

@@ -67 +67 @@
     result->m_domAttribute = domAttribute;
     result->m_customAccessor = customGetter ? FunctionPtr<OperationPtrTag>(customGetter) : nullptr;
-    return result;
+    return std::unique_ptr<AccessCase> { WTFMove(result) };
 }
 
@@ -77 +77 @@
     std::unique_ptr<GetterSetterAccessCase> result(new GetterSetterAccessCase(vm, owner, type, offset, structure, conditionSet, false, nullptr, customSlotBase, WTFMove(prototypeAccessChain)));
     result->m_customAccessor = customSetter ? FunctionPtr<OperationPtrTag>(customSetter) : nullptr;
-    return result;
+    return std::unique_ptr<AccessCase> { WTFMove(result) };
 }
 
@@ -98 +98 @@
     std::unique_ptr<GetterSetterAccessCase> result(new GetterSetterAccessCase(*this));
     result->resetState();
-    return result;
+    return std::unique_ptr<AccessCase> { WTFMove(result) };
 }
 

trunk/Source/JavaScriptCore/bytecode/InstanceOfAccessCase.cpp

@@ -48 +48 @@
     std::unique_ptr<InstanceOfAccessCase> result(new InstanceOfAccessCase(*this));
     result->resetState();
-    return result;
+    return std::unique_ptr<AccessCase> { WTFMove(result) };
 }
 

trunk/Source/JavaScriptCore/bytecode/IntrinsicGetterAccessCase.cpp

@@ -52 +52 @@
     std::unique_ptr<IntrinsicGetterAccessCase> result(new IntrinsicGetterAccessCase(*this));
     result->resetState();
-    return result;
+    return std::unique_ptr<AccessCase> { WTFMove(result) };
 }
 

trunk/Source/JavaScriptCore/bytecode/ModuleNamespaceAccessCase.cpp

@@ -59 +59 @@
     std::unique_ptr<ModuleNamespaceAccessCase> result(new ModuleNamespaceAccessCase(*this));
     result->resetState();
-    return result;
+    return std::unique_ptr<AccessCase> { WTFMove(result) };
 }
 

trunk/Source/JavaScriptCore/bytecode/ProxyableAccessCase.cpp

@@ -53 +53 @@
     std::unique_ptr<ProxyableAccessCase> result(new ProxyableAccessCase(*this));
     result->resetState();
-    return result;
+    return std::unique_ptr<AccessCase> { WTFMove(result) };
 }